Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding types information on the API surface. #918

Open
gabrieldemarmiesse opened this issue Jan 20, 2020 · 2 comments · Fixed by #947, #1399, #1404 or #1411
Open

Adding types information on the API surface. #918

gabrieldemarmiesse opened this issue Jan 20, 2020 · 2 comments · Fixed by #947, #1399, #1404 or #1411
Labels
contribution welcome good first issue Easy to solve. Beginner-friendly. pinned

Comments

@gabrieldemarmiesse
Copy link
Contributor

gabrieldemarmiesse commented Jan 20, 2020 •
edited
Loading

Adding types on the public API surface would allow us to do some runtime type checking later on and would allow user's IDE to have more info for static analysis.

The functions/signatures to type are the ones listed here https://github.com/keras-team/autokeras/blob/master/autokeras/__init__.py

For the context, see #856 where I add some type information on a ImageClassifier.

This issue can be considered easy to solve (good first issue), it's just long to do because the public API surface is big.

I'll do it but some help is welcome :) make sure to make small pull requests.
@gabrieldemarmiesse gabrieldemarmiesse mentioned this issue Feb 8, 2020
Merged
@gabrieldemarmiesse
Copy link
Contributor Author

gabrieldemarmiesse commented Feb 8, 2020 •
edited
Loading

We're going to have a nice TODO list with tensorflow/addons#1051 . Then we'll be able to track easily what's left and we'll avoid regressions with it.
@gabrieldemarmiesse gabrieldemarmiesse mentioned this issue Feb 9, 2020
Merged
@haifeng-jin haifeng-jin linked a pull request Feb 9, 2020 that will close this issue
Added typing check. #947
Merged
@haifeng-jin haifeng-jin reopened this Feb 9, 2020
@t-wtnb t-wtnb mentioned this issue Jul 7, 2020
Merged
@mandalbiswadip mandalbiswadip mentioned this issue Aug 8, 2020
Merged
dineshkumarsarangapani added a commit to dineshkumarsarangapani/autokeras that referenced this issue Oct 23, 2020
@dineshkumarsarangapani
Fix for typed api issue keras-team#918
1754fd5
Merged
dineshkumarsarangapani added a commit to dineshkumarsarangapani/autokeras that referenced this issue Oct 23, 2020
@dineshkumarsarangapani
Fix for typed api issue keras-team#918
c9c6549
haifeng-jin pushed a commit that referenced this issue Oct 26, 2020
@dineshkumarsarangapani @haifeng-jin
Fix for typed api issue #918
a96c9eb
dineshkumarsarangapani added a commit to dineshkumarsarangapani/autokeras that referenced this issue Oct 27, 2020
@dineshkumarsarangapani
fix for typed api keras-team#918
41b8770
Closed
dineshkumarsarangapani added a commit to dineshkumarsarangapani/autokeras that referenced this issue Oct 27, 2020
@dineshkumarsarangapani
Fix for typed API keras-team#918
266db41
Merged
haifeng-jin pushed a commit that referenced this issue Nov 1, 2020
@dineshkumarsarangapani @haifeng-jin
Fix for typed API #918
6550f22
Merged
@haifeng-jin haifeng-jin reopened this Dec 2, 2020
@keremgocen
Copy link

how's this going? any more help needed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome good first issue Easy to solve. Beginner-friendly. pinned
3 participants
@keremgocen @haifeng-jin @gabrieldemarmiesse