Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the indicator resource endpoint from the old version of Summar… #41707

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Change the indicator resource endpoint from the old version of Summar… #41707

merged 4 commits into from
Aug 2, 2023

Conversation

MorningSunKing
Copy link
Contributor

…y API to metrics resource
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 21, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @MorningSunKing!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 21, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 21, 2023
@netlify
Copy link

netlify bot commented Jun 21, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 62673a7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/649a6093fc40d200083e0e02
😎 Deploy Preview https://deploy-preview-41707--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
@mengjiao-liu
Copy link
Member

Preview page: https://deploy-preview-41707--kubernetes-io-main-staging.netlify.app/docs/tasks/debug/debug-cluster/resource-metrics-pipeline/
@mengjiao-liu mengjiao-liu mentioned this pull request Jun 21, 2023
Merged
@pacoxu
Copy link
Member

pacoxu commented Jun 26, 2023

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
mengjiao-liu
mengjiao-liu reviewed Jun 26, 2023
View reviewed changes
content/en/docs/tasks/debug/debug-cluster/resource-metrics-pipeline.md Outdated
@@ -50,7 +50,7 @@ P[pod data] -.- C
end
L[API<br>server]
W[HPA]
C ---->|Summary<br>API| A -->|metrics<br>API| L --> W
C ---->|metrics<br>resource| A -->|metrics<br>API| L --> W
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
C ---->|metrics<br>resource| A -->|metrics<br>API| L --> W
C ---->|metrics resource<br>API| A -->|metrics<br>API| L --> W

It's easier to understand.

Have any suggestions？@sftim @tengqm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the suggested change.

  • Metrics resource api is clearer than metrics resource for /metrics/resource API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
C ---->|metrics<br>resource| A -->|metrics<br>API| L --> W
C ---->|node level<br>resource metrics| A -->|metrics<br>API| L --> W
sftim
sftim reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

This PR only makes part of the necessary changes. We should amend it before we merge.
content/en/docs/tasks/debug/debug-cluster/resource-metrics-pipeline.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If making this change, you must also change:

* [Summary API](#summary-api-source): API provided by the kubelet for discovering and retrieving
  per-node summarized stats available through the `/stats` endpoint.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If making this change, you must also change:

* [Summary API](#summary-api-source): API provided by the kubelet for discovering and retrieving
  per-node summarized stats available through the `/stats` endpoint.

Done.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot requested a review from pacoxu June 26, 2023 15:37
@tengqm
Copy link
Contributor

tengqm commented Aug 2, 2023

/label tide/merge-method-squash
@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 2, 2023
@tengqm
Copy link
Contributor

tengqm commented Aug 2, 2023

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07c4a1497e45df1db8b3b77548d71ffad7db9489
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 594aa21 into kubernetes:main Aug 2, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
6 participants
@MorningSunKing @k8s-ci-robot @mengjiao-liu @pacoxu @tengqm @sftim