-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bugs of backup_restore
tool
#333
Conversation
Signed-off-by: loheagn <loheagn@icloud.com>
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 75.13% 76.58% +1.45%
==========================================
Files 24 24
Lines 1701 1764 +63
==========================================
+ Hits 1278 1351 +73
+ Misses 344 335 -9
+ Partials 79 78 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
if backendNS != "" { | ||
goto end | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic isn't that complex. Using If Else
is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
log.Printf("WARN: get terraform-controller deployment in the vela-system namesapce failed, %v", err) | ||
return "" | ||
} | ||
envs := deployment.Spec.Template.Spec.Containers[0].Env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better if we check the container's name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right.
Signed-off-by: loheagn <loheagn@icloud.com>
…ESPACE` env from terraform-controller deployment Signed-off-by: loheagn <loheagn@icloud.com>
Signed-off-by: loheagn <loheagn@icloud.com>
backup_restore
tool failedTERRAFORM_BACKEND_NAMESPACE
env from the terraform-controller deployment if user doesn't set it in the local environmentSigned-off-by: loheagn loheagn@icloud.com