Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix ucloud region #334

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

leason00
Copy link
Member

@leason00 leason00 commented Aug 5, 2022

Signed-off-by: lisen lisen@youzan.com
#335

Signed-off-by: lisen <lisen@youzan.com>
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #334 (689a4db) into master (ce3902a) will increase coverage by 1.36%.
The diff coverage is 84.26%.

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   75.13%   76.49%   +1.36%     
==========================================
  Files          24       24              
  Lines        1701     1757      +56     
==========================================
+ Hits         1278     1344      +66     
+ Misses        344      335       -9     
+ Partials       79       78       -1     
Flag Coverage Δ
e2e 0.00% <ø> (ø)
unit 79.76% <84.26%> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/configuration/configuration.go 93.06% <ø> (ø)
controllers/configuration_controller.go 77.53% <83.72%> (+2.65%) ⬆️
controllers/provider/credentials.go 92.63% <100.00%> (ø)
controllers/provider/ucloud.go 100.00% <100.00%> (ø)
controllers/rbac.go 90.66% <0.00%> (+1.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chivalryq chivalryq merged commit cd3c258 into kubevela:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants