Fix: apply job recreation #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 76.49% 76.58% +0.09%
==========================================
Files 24 24
Lines 1757 1764 +7
==========================================
+ Hits 1344 1351 +7
Misses 335 335
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Somefive
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, if we restart terraform-controller with
--controller-namespace. It couldn't get legacy Apply Job which is proves the resources has been created.This PR fix it by getting both kind of apply job.
Trim some useless code.
Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com