-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for specifying job environment variables #337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 76.58% 79.31% +2.72%
==========================================
Files 24 23 -1
Lines 1764 1750 -14
==========================================
+ Hits 1351 1388 +37
+ Misses 335 278 -57
- Partials 78 84 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ee4b8fd
to
1adb81d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you illustrate why we need ProviderVariable in Configuration? How it is related to provider? What's the difference with Credentials
in Provider?
such as
If I want to create resources in different projects, I need to create multiple Provider。 |
c1aadaa
to
8e3ae65
Compare
4707a34
to
65c99fb
Compare
65c99fb
to
edc0b56
Compare
But we don't have a concept of Provider environment. How could it affect with the properties of a provider? |
Add or overwrite |
Otherwise, like Ucloud's PrjID, we need to create a lot of Provider, and the secret key is the same, only the PrjID is different, if you need to modify the key, this is a big project. |
Would it be better if we extend a env fields for more general purpose? Maybe there are similar issues in the future. |
edc0b56
to
c168aa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after fix these.
Signed-off-by: lisen <lisen@youzan.com>
c168aa3
to
a58c296
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Fixes: #319
Signed-off-by: lisen lisen@youzan.com