Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: async delete cause duplicated destroy #342

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

chivalryq
Copy link
Member

Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #342 (3a96f68) into master (1f49401) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files          23       23           
  Lines        1750     1750           
=======================================
  Hits         1388     1388           
  Misses        278      278           
  Partials       84       84           
Flag Coverage Δ
e2e ?
unit 79.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/configuration_controller.go 77.35% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@leason00
Copy link
Member

lgtm

@Somefive Somefive merged commit d9360c0 into kubevela:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants