-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add libc6-compat to fix dynamic linking issue, add ca-certificates #353
feat: add libc6-compat to fix dynamic linking issue, add ca-certificates #353
Conversation
… for provider built with ubuntu. add ca-certificates to add well known cers to the truststore. Signed-off-by: raradhakrishnan <raradhakrishnan@guidewire.com>
cf4c0c8
to
a4f8b26
Compare
Codecov ReportBase: 79.31% // Head: 80.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 79.31% 80.36% +1.04%
==========================================
Files 23 23
Lines 1750 1935 +185
==========================================
+ Hits 1388 1555 +167
- Misses 278 290 +12
- Partials 84 90 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@ramekris3163 What are the problems the two lib solved? Can you give a more detailed explanation? |
The libc6-compat apk allows alpine to support dynamic linking in libraries. For ex when a provider is built in ubuntu , by default it has dynamic linking of libraries, when we try to use the library in alpine it fails like this hashicorp/terraform-provider-helm#59 and to fix this we need to add libc6-compat library. The ca-certificates apk adds well known certificates to the trust store of the container so that it will be able to connect to SSL with root CA Certificates. |
Got it. LGTM! |
add libc6-compat library to fix dynamic linking issue in alpine for provider built with ubuntu. add ca-certificates to add well known cers to the truststore.