Fix: reconcile after configuration's hcl changed #360
Conversation
Signed-off-by: xingming01 <whatissoftware@163.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
==========================================
- Coverage 79.31% 77.54% -1.77%
==========================================
Files 23 24 +1
Lines 1750 2053 +303
==========================================
+ Hits 1388 1592 +204
- Misses 278 366 +88
- Partials 84 95 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| if kerrors.IsNotFound(err) { | ||
| return nil | ||
| } | ||
| return err |
There was a problem hiding this comment.
| if kerrors.IsNotFound(err) { | |
| return nil | |
| } | |
| return err | |
| return client.IgnoreNotFound(err) |
Signed-off-by: xingming01 <whatissoftware@163.com>
Added, thanks |
| "create configuration for the first time": { | ||
| args: args{ | ||
| meta: &TFConfigurationMeta{ | ||
| ConfigurationCMName: "aa", | ||
| Namespace: "b", | ||
| ControllerNamespace: "b", | ||
| }, | ||
| configurationType: "HCL", | ||
| }, | ||
| want: want{ | ||
| errMsg: "", |
There was a problem hiding this comment.
Case "Configuration is changed" is not tested, which is the point of this PR. Can you add some test for that?
There was a problem hiding this comment.
Case "Configuration is changed" is not tested, which is the point of this PR. Can you add some test for that?
A case "Configuration changed, and reconcile"" was added
Signed-off-by: xingming01 <whatissoftware@163.com>
Reconcile again after configuration's hcl changed
Fixes #359