Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Supports marking a job as failed after specifying a few retries… #362

Merged
merged 2 commits into from
May 19, 2023
Merged

feat: Supports marking a job as failed after specifying a few retries… #362

merged 2 commits into from
May 19, 2023

Conversation

wujiuye
Copy link
Contributor

@wujiuye wujiuye commented May 18, 2023

… #361
@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 85.18% and project coverage change: -2.27 ⚠️

Comparison is base (3a96f68) 79.31% compared to head (cebbd32) 77.05%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   79.31%   77.05%   -2.27%     
==========================================
  Files          23       24       +1     
  Lines        1750     2022     +272     
==========================================
+ Hits         1388     1558     +170     
- Misses        278      371      +93     
- Partials       84       93       +9
Flag Coverage Δ
e2e 0.00% <ø> (∅)
unit 79.89% <85.18%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/configuration/configuration.go 92.22% <0.00%> (-3.19%) ⬇️
controllers/terraform/status.go 77.41% <ø> (ø)
e2e/normal/regression.go 0.00% <ø> (ø)
controllers/configuration_controller.go 78.96% <86.38%> (+1.60%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
chivalryq
chivalryq approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is generally LGTM. We can consider make it a configuration level properties.
chart/values.yaml Outdated
@@ -12,6 +12,7 @@ controllerNamespace: ""

# "{\"nat\": \"true\"}"
jobNodeSelector: ""
jobBackoffLimit:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A default value?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is the maximum value of int, compatible with the original default value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "" instead of just leaving it empty.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your point of view.
@chivalryq
Copy link
Member

Also please sign the DCO by git commit --signoff
Values.jobBackoffLimit defaults to ""
cebbd32 
Signed-off-by: 吴就业 <wujiuye@lizhi.fm>
@chivalryq chivalryq merged commit 6e51e97 into kubevela:master May 19, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@wujiuye @chivalryq