fix: The execution of the terraformDestroy method fails and the appli… #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
- Coverage 79.31% 76.82% -2.49%
==========================================
Files 23 24 +1
Lines 1750 2054 +304
==========================================
+ Hits 1388 1578 +190
- Misses 278 379 +101
- Partials 84 97 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…ation cannot be uninstalled kubevela#363 Signed-off-by: 吴就业 <wujiuye@lizhi.fm>
wujiuye
force-pushed
the
fix-terraform-destroy
branch
from
0f81fc9
to
672d815
Compare
chivalryq
reviewed
May 30, 2023
Comment on lines
1138
to
1141
| if len(tfState.Outputs) == 0 { | ||
| return false | ||
| } | ||
| return true |
There was a problem hiding this comment.
return len(tfState.Outputs) > 0
Comment on lines
185
to
187
| // fix: The failure of terraformApply does not mean that it has never been successful, | ||
| // but if the 'tfstate' file does not exist, then there is no need for terraformDestroy, | ||
| // which can quickly clean up resources. |
There was a problem hiding this comment.
Suggested change
| // fix: The failure of terraformApply does not mean that it has never been successful, | |
| // but if the 'tfstate' file does not exist, then there is no need for terraformDestroy, | |
| // which can quickly clean up resources. | |
| // If no tfState has been generated, then perform a quick cleanup without dispatching destroying job. | |
| } else { | ||
| klog.Infof("No need to execute terraform destroy command, because tfstate file not found: %s/%s", configuration.Namespace, configuration.Name) | ||
| if err := r.cleanUpSubResources(ctx, configuration, meta); err != nil { | ||
| klog.Warningf("Failed to clean up sub-resources, but it's ignored as the resources are being forced to delete: %s", err) |
There was a problem hiding this comment.
No clue suggests the "configuration" is force to delete.
Suggested change
| klog.Warningf("Failed to clean up sub-resources, but it's ignored as the resources are being forced to delete: %s", err) | |
| klog.Warningf("Ignoring error when clean up sub-resources, for no resource is actually created: %s", err) |
Signed-off-by: 吴就业 <wujiuye@lizhi.fm>
chivalryq
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cation cannot be uninstalled(#363)