ISSUE-376: Removing the condition that looks for outputs in tfstate to decide if tfstate is generated or not

[jaswalkiranavtar]

This PR is to fix this issue.

Terraform scripts should be treated valid even without outputs.

[codecov]

Codecov Report

Patch coverage: 81.46% and project coverage change: -1.70% ⚠️

Comparison is base (3a96f68) 79.31% compared to head (54a027a) 77.61%.
Report is 17 commits behind head on master.

❗ Current head 54a027a differs from pull request most recent head 34b28a5. Consider uploading reports for the commit 34b28a5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   79.31%   77.61%   -1.70%     
==========================================
  Files          23       24       +1     
  Lines        1750     2046     +296     
==========================================
+ Hits         1388     1588     +200     
- Misses        278      364      +86     
- Partials       84       94      +10     

Flag	Coverage Δ
e2e	0.00% <ø> (∅)
unit	80.44% <81.46%> (+1.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
controllers/configuration/configuration.go	92.22% <0.00%> (-3.19%)	⬇️
controllers/terraform/status.go	77.41% <ø> (ø)
e2e/normal/regression.go	0.00% <ø> (ø)
controllers/configuration_controller.go	79.94% <82.42%> (+2.58%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chivalryq]

LGTM. Please sign the DCO to pass test.

[jaswalkiranavtar]

@chivalryq Signed DCO, i still see codecov check fails. Our commit should not bring codecov down as we have not changed a lot, just removed a condition. Could you please help resolve this and merge the PR?

[chivalryq]

Sometimes codecov it not concise.