Fix: Keep the backend secret when clean up SubResources if the deleteResou… #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 79.31% 72.92% -6.40%
==========================================
Files 23 27 +4
Lines 1750 2068 +318
==========================================
+ Hits 1388 1508 +120
- Misses 278 471 +193
- Partials 84 89 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
chivalryq
reviewed
Sep 22, 2023
| @@ -1569,6 +1572,16 @@ func TestTerraformDestroy(t *testing.T) { | |||
| objects: []client.Object{readyProvider, configurationWithConnSecret, baseConfigurationCM, completeDestroyJob, baseVariableSecret, connectionSecret}, | |||
| deletedResources: []client.Object{baseConfigurationCM, completeDestroyJob, baseVariableSecret, connectionSecret}, | |||
| }, | |||
| { | |||
| name: "destroy job has completes, cleanup resources but backend secret", | |||
There was a problem hiding this comment.
Suggested change
| name: "destroy job has completes, cleanup resources but backend secret", | |
| name: "destroy job has completes, cleanup resources except backend secret", |
| }, | ||
| want: want{}, | ||
| objects: []client.Object{readyProvider, configurationWithConnSecret, baseConfigurationCM, completeDestroyJob, baseVariableSecret, connectionSecret}, | ||
| deletedResources: []client.Object{baseConfigurationCM, completeDestroyJob, baseVariableSecret, connectionSecret}, |
There was a problem hiding this comment.
Backend secret should be added to keptResources to test this PR. I think now this condition is not tested.
There was a problem hiding this comment.
I missed this test case about keptResources , and I will add it.
…rces is false. Signed-off-by: imzhangsiwei <flysqrlboy@gmail.com>
…ce set to false Signed-off-by: imzhangsiwei <flysqrlboy@gmail.com>
chivalryq
approved these changes
Sep 22, 2023
imzhangsiwei
force-pushed
the
fix-keep-backendsecret-deleteResource-false
branch
from
8fb9882
to
2d33b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rces is false.
#380