Add Winloop to the Harvester as a performance enhancement #1766
Conversation
|
Thank you for the PR, I am glad to see the project has matured since you originally made the initial PR. Did you have any success talking to the developers of uvloop and integrating it into uvloop? |
|
On Thu, Jun 27, 2024 at 2:58 PM Matt ***@***.***> wrote:
Thank you for the PR, I am glad to see the project has matured since you
originally made the initial PR. Did you have any success talking to the
developers of uvloop and integrating it into uvloop?
—
Reply to this email directly, view it on GitHub
<#1766 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3K7GGTYSKZYPAAVQ4HM7RTZJRVH7AVCNFSM6AAAAABKAP7FVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGU3TANJWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
I have a contributor that is working on getting it merged I just don’t know
how long it will take for it to be finished.
|
|
@Vizonex you also need to do your change in bin/theHarvester as that is missing also :-) |
Thanks for pointing that out I have made my changes to the bin folder. |
|
Sorry for asking but is there anything I need to do to get this passed? |
|
Can you make sure it passes the liniter/formatter please |
|
I sure can
…On Tue, Jul 9, 2024 at 3:18 AM J.Townsend ***@***.***> wrote:
Can you make sure it passes the liniter/formatter please
—
Reply to this email directly, view it on GitHub
<#1766 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3K7GGVGHUZMUTEJ2O3DPBLZLOMGDAVCNFSM6AAAAABKAP7FVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWHEYTCMJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I had a friend help with with this commit. We just linted the code with black for you |
|
Our linter/formatter is ruff not black, we moved from black to ruff as it's one tool that can do everything and imo much better than black. |
It has been somewhat of a dream of mine to see this library be added to this amazing OSINT/Pentesting tool and for the longest time it has been of goal of mine to make the harvester run smoother on windows. I can proudly say that winloop has matured since I originally proposed using it in this project a long time ago. I have also added support for aiodns with winloop and I have also tested screenshotting with the enhanced event loop and all seems to run very well, another thing I did was I made importing it entirely optional however feel free to let me know if the import failure workaround should be dropped.