Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can not star bug also add test #49

Merged
merged 1 commit into from
Aug 21, 2020
Merged

fix: can not star bug also add test #49

merged 1 commit into from
Aug 21, 2020

Conversation

yihong0618
Copy link

No description provided.

@yihong0618
Copy link
Author

yihong0618 commented Aug 21, 2020 •
edited
Loading

@jdneo forget yesterday's pr ~, I forgot to delete my fork, this time also add test too.
jdneo
jdneo reviewed Aug 21, 2020
View reviewed changes
Copy link

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this change break the cn endpoint?
@yihong0618
Copy link
Author

yihong0618 commented Aug 21, 2020 •
edited
Loading

will this change break the cn endpoint?

No will not break, test for cn either also work fine.

I think leetcode-cn not close old api yet, they keep both now.
@jdneo
Copy link

jdneo commented Aug 21, 2020

Thanks @yihong0618
@jdneo jdneo merged commit cd5d4ef into leetcode-tools:master Aug 21, 2020
@yihong0618 yihong0618 mentioned this pull request Sep 10, 2020
Open
@yihong0618 yihong0618 mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@yihong0618 @jdneo