Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plane decomposition launch and run.sh #80

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

Divelix
Copy link
Contributor

@Divelix Divelix commented Jan 26, 2024

I just started to explore this repo and found 2 typos I had to fix to be able to follow tutorial examples with turtlebot:

  • build.sh creates image with name elevation_mapping_cupy:latest, while run.sh assumes this image named mktk1117/elevation_mapping_cupy:latest
  • turtlesim_plane_decomposition_example.launch includes turtlesim_example.launch, when there is no such launch. I assumed that turtlesim_simple_example.launch should be included instead and then everything launched fine.
@mktk1117
Copy link
Collaborator

Thanks a lot for your PR!
For the first point, actually there should be a image called mktk1117/elevation_mapping_cupy:latest in the dockerhub.
Maybe it's better to have an option to choose which to use.

@Divelix
Copy link
Contributor Author

Divelix commented Feb 1, 2024

Oh, ok, now it seems obvious. I will remove my change in image name and update README, it should be enough.

@mktk1117 mktk1117 merged commit 69aea24 into leggedrobotics:main Feb 24, 2024
@Divelix Divelix deleted the fix/run branch February 25, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants