Added support for '.' in Bucket Name #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected String getEndpoint(JsonObject parameters, String host) { | ||
| if (parameters.has(KEY_BUCKET_NAME)) { | ||
| String bucketName = parameters.get(KEY_BUCKET_NAME).getAsString().toLowerCase(); | ||
| host = host.toLowerCase(Locale.ROOT).replace(bucketName, ""); |
There was a problem hiding this comment.
minor concern butt I don't see the tolowercase used in the original getEndpointFromHost method. Is there an existing use case that has issues with cases?
There was a problem hiding this comment.
We are replacing bucket name from the host, if some client enters bucket name in different case as in the source uri. It won't be replaced properly.
| * | ||
| * @param parameters JsonObject containing ms.source.s3.parameters | ||
| * @param host hostname with bucket name in the beginning | ||
| * @return the endpoint name without the bucket name |
There was a problem hiding this comment.
nit: in the comment maybe add some details to explain its difference from getEndpointFromHost. That will help with debugging in the future
There was a problem hiding this comment.
Sure, I will add
| new Gson().fromJson("{\"region\" : \"us-east-2\", \"bucket_name\" : \"colleCt-us-west-2.tealium.com\"}", | ||
| JsonObject.class); | ||
| String host = "collect-us-west-2.tealium.com.s3.amazonaws.com"; | ||
| String endpoint = s3SourceV2.getEndpoint(parameteres, host); |
There was a problem hiding this comment.
nit: parameteres -> parameters
There was a problem hiding this comment.
Sure with fix the typo.
dihu-linkedin
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear DIL maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
So added a new parameter in ms.source.s3.parameters for bucket name as "bucket_name" which would help to navigate through the edge cases.
Tests
Commits