[BottomSheet] Fix SettleRunnable leak #1670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that we don't post the `SettleRunnable` if the view isn't attached, because otherwise if there is no alive activity that `SettleRunnable` can stay in the ViewRootImpl `RunQueue` until a new activity starts. Fixes material-components#1417.
pyricau
commented
Aug 31, 2020
| @@ -1324,7 +1324,7 @@ void startSettlingAnimation(View child, int state, int top, boolean settleFromVi | |||
| settleRunnable = new SettleRunnable(child, state); | |||
| } | |||
| // If the SettleRunnable has not been posted, post it with the correct state. | |||
| if (settleRunnable.isPosted == false) { | |||
| if (!settleRunnable.isPosted) { | |||
There was a problem hiding this comment.
unrelated but the IDE warning was in my face so I couldn't resist.
drchen
reviewed
Jul 15, 2021
|
@drchen sorry just catching up with GitHub notifications. That was a few months back so I don't recall all the details, but I did write this in the issue:
To be clear, I haven't reproduced the bug directly, this is all based on leak reports which show this happening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that we don't post the
SettleRunnableif the view isn't attached, because otherwise if there is no alive activity thatSettleRunnablecan stay in the ViewRootImplRunQueueuntil a new activity starts.Fixes #1417.