[BottomSheetBehavior] specially treat child's top margin #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emakar
force-pushed
the
bottom-sheet-top-margin
branch
2 times, most recently
from
a5d8307
to
d2c9480
Compare
so that it contributes to expanded offset
emakar
force-pushed
the
bottom-sheet-top-margin
branch
from
d2c9480
to
5c7819b
Compare
|
I've done more testing and left only special top margin treatment This is ready for review |
|
Any update on this one? It looks like it might also fix the issue with that standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed BottomSheetBehavior to work with top margin being set to its view.
Currently this is buggy and gives various card jumps.
I also need this behavior with fitToContents = true