[Text Field] Add ability to provide helperText custom horizontal padding #3141
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| boolean isFontScaleLarge, @DimenRes int largeFontPaddingRes, int defaultPadding) { | ||
| if (helperTextHorizontalPaddingPx != NO_HELPER_TEXT_HORIZONTAL_PADDING) | ||
| return helperTextHorizontalPaddingPx; | ||
| else |
There was a problem hiding this comment.
Please always use brackets.
| getIndicatorHorizontalPadding( | ||
| isFontScaleLarge, | ||
| R.dimen.material_helper_text_font_1_3_padding_horizontal, | ||
| ViewCompat.getPaddingStart(editText)), | ||
| getIndicatorPadding( |
There was a problem hiding this comment.
I feel we probably need some refactoring here.
To make the code more clear, I think we should create separate methods getHelperTextVerticalPadding and getHelperTextHorizontalPadding, and call getIndicatorPadding from them.
There was a problem hiding this comment.
@drchen I didn't catch your idea. We have only horizontal padding option for now. What is the purpose of getHelperTextVerticalPadding then? getIndicatorHorizontalPadding encapsulates padding resolution logic. Can you reformulate your suggestion?
| @@ -187,6 +187,8 @@ | |||
| */ | |||
| public class TextInputLayout extends LinearLayout { | |||
|
|
|||
| static final int NO_HELPER_TEXT_HORIZONTAL_PADDING = -1; | |||
There was a problem hiding this comment.
The constant name is not accurate. Maybe just USE_DEFAULT_PADDING?
build.gradle
Outdated
| @@ -59,7 +59,7 @@ ext { | |||
| ? project.property('mavenRepoUrl') : '/tmp/myRepo/') | |||
|
|
|||
| // Current version of the library (could be in-development/unreleased). | |||
| mdcLibraryVersion = '1.6.1' | |||
| mdcLibraryVersion = '1.6.2' | |||
|
@drchen Hi! Any others questions? |
Thanks for starting a pull request on Material Components!
Don't forget:
[Buttons] Updated documentationContributing
has more information and tips for a great pull request.