-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Related: #194 Reviewers: O2 Material Motion, O3 Material JavaScript platform reviewers, #material_motion, featherless Reviewed By: O2 Material Motion, #material_motion, featherless Subscribers: featherless Tags: #material_motion Differential Revision: http://codereview.cc/D3129
- Loading branch information
1 parent
52c2e42
commit f3520bb
Showing
5 changed files
with
112 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/** @license | ||
* Copyright 2016 - present The Material Motion Authors. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
* use this file except in compliance with the License. You may obtain a copy | ||
* of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { | ||
MotionObservable, | ||
} from '../observables'; | ||
|
||
// ObservableWithMotionOperators isn't referenced in this file, but TypeScript | ||
// gets mad if you remove it. (MotionProperty is using MotionDebounceable from | ||
// an external module) | ||
import { | ||
ObservableWithMotionOperators, | ||
withMotionOperators, | ||
} from '../operators'; | ||
|
||
import { | ||
Operable, | ||
} from '../types'; | ||
|
||
import { | ||
ReactiveProperty, | ||
} from './ReactiveProperty'; | ||
|
||
export class OperableProperty<T> extends ReactiveProperty<T> implements Operable<T> { | ||
_observableConstructor = MotionObservable; | ||
} | ||
export const MotionProperty = withMotionOperators(OperableProperty); | ||
export default MotionProperty; |
64 changes: 64 additions & 0 deletions
64
packages/core/src/properties/__tests__/motionProperty.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/** @license | ||
* Copyright 2016 - present The Material Motion Authors. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
* use this file except in compliance with the License. You may obtain a copy | ||
* of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { expect } from 'chai'; | ||
|
||
import { | ||
beforeEach, | ||
describe, | ||
it, | ||
} from 'mocha-sugar-free'; | ||
|
||
import { | ||
spy, | ||
} from 'sinon'; | ||
|
||
import MotionProperty from '../MotionProperty'; | ||
|
||
declare function require(name: string); | ||
|
||
// chai really doesn't like being imported as an ES2015 module; will be fixed in v4 | ||
require('chai').use( | ||
require('sinon-chai') | ||
); | ||
|
||
describe('motionProperty', | ||
() => { | ||
let property; | ||
let listener; | ||
|
||
beforeEach( | ||
() => { | ||
property = new MotionProperty(); | ||
|
||
listener = spy(); | ||
} | ||
); | ||
|
||
it(`should be a property with operators`, | ||
() => { | ||
property.pluck('a').subscribe(listener); | ||
|
||
property.write({ 'a': 1 }); | ||
|
||
expect(listener).to.have.been.calledOnce.and.to.have.been.calledWith(1); | ||
} | ||
); | ||
|
||
// It would be more thorough to re-run the ReactiveProperty and operator | ||
// test suites here, but I'm not sure it adds value/ | ||
} | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters