-
Notifications
You must be signed in to change notification settings - Fork 13
Add system timing constant for movement during modal presentation. #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't get me wrong, I love C-based inheritance as much as anyone, but in Objective-C it starts looking a little perverse at times. Is there some reason why these are little data classes so you don't have to do the static initialization and the resulting #define macros?
Old habits die hard - will happily consider switching to Objective-C classes! |
The original thinking was to minimize memory use, but that's hardly a strong consideration here. |
Is the intention to change this macro into a class? I typically prefer a static MDMMotionCurve that is defined in the implementation over a macro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer static over macro?
I'll have to explore doing so in a follow-up major release. For now we require the macros in order to do static struct initialization. |
Gentle ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's file an issue to track removing the structs and their required #defines.
Filed #5 to track. |
No description provided.