Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Add system timing constant for movement during modal presentation. #4

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

jverkoey
Copy link
Contributor

No description provided.

Copy link

@ajsecord ajsecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get me wrong, I love C-based inheritance as much as anyone, but in Objective-C it starts looking a little perverse at times. Is there some reason why these are little data classes so you don't have to do the static initialization and the resulting #define macros?

@jverkoey
Copy link
Contributor Author

Old habits die hard - will happily consider switching to Objective-C classes!

@jverkoey
Copy link
Contributor Author

The original thinking was to minimize memory use, but that's hardly a strong consideration here.

@ianegordon
Copy link

Is the intention to change this macro into a class?

I typically prefer a static MDMMotionCurve that is defined in the implementation over a macro.

Copy link

@ianegordon ianegordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer static over macro?

@jverkoey
Copy link
Contributor Author

I'll have to explore doing so in a follow-up major release. For now we require the macros in order to do static struct initialization.

@jverkoey
Copy link
Contributor Author

Gentle ping.

Copy link

@ajsecord ajsecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's file an issue to track removing the structs and their required #defines.

@jverkoey
Copy link
Contributor Author

Filed #5 to track.

@jverkoey jverkoey merged commit bf757fe into develop Aug 30, 2017
@jverkoey jverkoey deleted the modalmovement branch August 30, 2017 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants