Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdn_urls for DOMMatrix properties #23649

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jul 3, 2024

These properties are documented inline on the interface page and there is no plan to create sub pages for them. The mdn_url linter doesn't know about this, so I'm adding the mdn_urls manually.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 3, 2024
@queengooborg
Copy link
Collaborator

I see all these links are for #instance_properties, but shouldn't we use the more specific hashes? For example, #m11?

@Elchi3
Copy link
Member Author

Elchi3 commented Jul 8, 2024

The MDN page only offers anchors for m11, not m12, or any other properties, so I thought it would be most safe to use the #instance_properties anchor.

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was only looking at the first anchor in those lists. Let's go for it in this form, then!

@queengooborg queengooborg merged commit fa98159 into mdn:main Jul 8, 2024
5 checks passed
@Elchi3 Elchi3 deleted the dommatrix-mdn_urls branch July 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
2 participants