Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firefox for Android web app manifest features #23661

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jonalmeida
Copy link
Contributor

Summary

Updating the state of web manifest properties that are used by Firefox for Android.

Members that are parsed by Gecko, but not used by Firefox for Android:

  • description
  • dir
  • lang
  • related_applications
  • prefer_related_applications
  • share_target

Members that are parsed by Gecko, but not used in Firefox and Firefox for Android:

  • id

Test results and supporting details

Related Firefox for Android bugs:

@jonalmeida
Copy link
Contributor Author

@Elchi3 could you advise if the updates below are correct by:

  • Taking inspiration from Updated Safari support for Web App Manifests #23640, we have marked only Firefox for Android as false for properties that are parsed by Gecko but we do not implement the feature.
  • Leaving Firefox as null even though they share the same engine that parses the manifest values.
@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jul 4, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @jonalmeida! 👍

I would say that we should set firefox desktop to false everywhere then. Do you want to do that in this PR or do you want me to do that in a follow-up?

@dipikabh
Copy link
Contributor

dipikabh commented Jul 8, 2024

@jonalmeida, in an offline discussion, Florian has suggested that we could use the following approach for manifest members that are parsed but do not currently cause any visible change for users. This could help convey the complete picture about the present "support" of the member.

"notes": "The property parses, but has no effect."

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't add suggestions for the following three members, but firefox_android also needs to have the same note there:

dir
lang
share_target

html/manifest/id.json Outdated Show resolved Hide resolved
html/manifest/id.json Show resolved Hide resolved
html/manifest/description.json Outdated Show resolved Hide resolved
html/manifest/related_applications.json Outdated Show resolved Hide resolved
html/manifest/prefer_related_applications.json Outdated Show resolved Hide resolved
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jul 11, 2024
@jonalmeida
Copy link
Contributor Author

jonalmeida commented Jul 11, 2024

@Elchi3 Sorry about the slow turn around time. I've update the PR with most of the recommendations. I do have one more question below:

I can't add suggestions for the following three members, but firefox_android also needs to have the same note there:

dir
lang

I noticed that there aren't any files for dir and lang at the moment (probably because of the note on MDN here that says they are not implemented in any engine). Should I create those files and mark firefox as false and firefox_android with the parsing note? If yes, should I do that in this PR or would it be better to make a separate one for clarity?

share_target

Done.

Members are parsed by Gecko and FireFox for Android, but not used:
 - `dir`
 - `lang`

Members are parsed by Firefox for Android, but not used by it:
 - `description`
 - `related_applications`
 - `prefer_related_applications`
 - `share_target`

Members that are parsed by Gecko, but not used in Firefox for
Android:
 - `id`

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jul 11, 2024
@Elchi3
Copy link
Member

Elchi3 commented Jul 11, 2024

I noticed that there aren't any files for dir and lang at the moment (probably because of the note on MDN here that says they are not implemented in any engine). Should I create those files and mark firefox as false and firefox_android with the parsing note? If yes, should I do that in this PR or would it be better to make a separate one for clarity?

Oh sorry, my bad, I was just going through your list above. It's fine to not add these files for the moment. We only add features to this repo when it sees at least one implementation somewhere and that is not given for these two. So that's all good as is. Thank you!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Thank you so much @jonalmeida and @dipikabh 👍

@Elchi3 Elchi3 merged commit 5276a97 into mdn:main Jul 11, 2024
6 checks passed
@jonalmeida jonalmeida deleted the web_app_manifest branch July 11, 2024 20:55
@dipikabh
Copy link
Contributor

Thanks a lot, @jonalmeida, for these updates and your diligence! 🙌
Thanks for reviewing, @Elchi3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
3 participants