-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Firefox for Android web app manifest features #23661
Conversation
@Elchi3 could you advise if the updates below are correct by:
|
e33c3f6
to
d8b3e86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @jonalmeida! 👍
I would say that we should set firefox desktop to false everywhere then. Do you want to do that in this PR or do you want me to do that in a follow-up?
@jonalmeida, in an offline discussion, Florian has suggested that we could use the following approach for manifest members that are parsed but do not currently cause any visible change for users. This could help convey the complete picture about the present "support" of the member. browser-compat-data/css/properties/d.json Line 27 in 40f2d89
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't add suggestions for the following three members, but firefox_android also needs to have the same note there:
dir
lang
share_target
d8b3e86
to
b36d21a
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
@Elchi3 Sorry about the slow turn around time. I've update the PR with most of the recommendations. I do have one more question below:
I noticed that there aren't any files for
Done. |
Members are parsed by Gecko and FireFox for Android, but not used: - `dir` - `lang` Members are parsed by Firefox for Android, but not used by it: - `description` - `related_applications` - `prefer_related_applications` - `share_target` Members that are parsed by Gecko, but not used in Firefox for Android: - `id` Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
b36d21a
to
cda72c4
Compare
Oh sorry, my bad, I was just going through your list above. It's fine to not add these files for the moment. We only add features to this repo when it sees at least one implementation somewhere and that is not given for these two. So that's all good as is. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Thank you so much @jonalmeida and @dipikabh 👍
Thanks a lot, @jonalmeida, for these updates and your diligence! 🙌 |
Summary
Updating the state of web manifest properties that are used by Firefox for Android.
Members that are parsed by Gecko, but not used by Firefox for Android:
description
dir
lang
related_applications
prefer_related_applications
share_target
Members that are parsed by Gecko, but not used in Firefox and Firefox for Android:
id
Test results and supporting details
Related Firefox for Android bugs: