Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web-features tag from deprecated Bluetooth writeValue() method #23670

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jul 5, 2024

Its inclusion causes a warning in web-features dist file generation. We
cannot deal with deprecated BCD keys yet because by definition
deprecated features cannot be Baseline.

This is the only deprecated BCD key currently tagged for web-features.

Its inclusion causes a warning in web-features dist file generation. We
cannot deal with deprecated BCD keys yet because by definition
deprecated features cannot be Baseline.

This is the only deprecated BCD key currently tagged for web-features.
@foolip foolip requested a review from ddbeck July 5, 2024 12:12
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 5, 2024
@foolip
Copy link
Collaborator Author

foolip commented Jul 5, 2024

@LeoMcA @fiji-flo @Rumyra this is the deprecated BCD key I mentioned. I'll just remove the tag so you don't need to consider this case for now.

@foolip foolip requested a review from queengooborg July 8, 2024 12:35
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this. Do you want to file a BCD issue so that we update the tag linter to disallow tagging deprecated feature?

@Elchi3 Elchi3 merged commit a840e75 into mdn:main Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
2 participants