Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputmode is supported on Firefox 79 for Android #6782

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

makotokato
Copy link
Contributor

Shipped by https://bugzilla.mozilla.org/show_bug.cgi?id=1631681.

Also, inputmode preference should be same version of Firefox Desktop.

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any
@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Sep 30, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 1, 2020

Thanks for this PR!

Also, inputmode preference should be same version of Firefox Desktop.

Do you want to include this change in this PR, @makotokato? I'd welcome that addition, or a follow-up. If you don't want to do it at all, we could open an issue to track that suggestion separately.

@foolip
Copy link
Collaborator

foolip commented Oct 9, 2020

I think only remaining question here is missing flag data. Since we're definitely missing flag data all over the place, that seems quite OK to me. It will become consistent in 2 years when the existing flag data can be removed :)

@makotokato
Copy link
Contributor Author

Do you want to include this change in this PR, @makotokato? I'd welcome that addition, or a follow-up. If you don't want to do it at all, we could open an issue to track that suggestion separately.

Hmm, OK, this PR is Firefox Android 79 only. So I will update this PR.

Also, I will file another PR that is #6468 is incorrect.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @makotokato!

Also, I wasn't entirely clear on what the situation was for Firefox on the desktop, so I opened #6921 to track that independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
3 participants