Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Chrome for storage manager quota #7846

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

beaufortfrancois
Copy link
Contributor

As noted in https://web.dev/storage-for-the-web/#:~:text=60%25%20of%20the%20actual%20disk%20size, Chrome always reports 60% of the actual disk size in the StorageManager API for privacy reasons.

@beaufortfrancois beaufortfrancois requested a review from a team as a code owner August 12, 2021 07:35
@beaufortfrancois beaufortfrancois requested review from Elchi3 and removed request for a team August 12, 2021 07:35
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/StorageEstimate/quota
Title: StorageEstimate.quota
on GitHub

No new external URLs

(this comment was updated 2021-08-16 09:59:06.591124)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Let's keep this note vendor neutral

@@ -28,6 +28,10 @@ <h3 id="Value">Value</h3>

<p>A numeric value specifying an approximation of the total amount of storage space available for use by the application.</p>

<div class="note">
<p><strong>Note</strong>: Chrome always reports 60% of the actual disk size for privacy reasons.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p><strong>Note</strong>: Chrome always reports 60% of the actual disk size for privacy reasons.</p>
<p><strong>Note:</strong> User agents might not report the actual storage space for privacy reasons.</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tryin to raise that the quota may be larger than what is actually available to websites. This is confusing to developers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "User agents might not report the actual storage space for privacy reasons. Chrome, for instance, always reports 60% of the actual disk size." work for you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be much better, imo. If you happen to know if it is just "Chrome" or rather "Chromium-based browsers", then that would be good to be precise about, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be Chrome-specific according to GoogleChrome/web.dev#3896

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated PR. Let me know if that still looks good to you.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for making the changes and alerting web devs about it. Cheers 🎉

@Elchi3 Elchi3 merged commit 9eb0316 into mdn:main Aug 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants