-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about Chrome for storage manager quota #7846
Conversation
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs (this comment was updated 2021-08-16 09:59:06.591124) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Let's keep this note vendor neutral
@@ -28,6 +28,10 @@ <h3 id="Value">Value</h3> | |||
|
|||
<p>A numeric value specifying an approximation of the total amount of storage space available for use by the application.</p> | |||
|
|||
<div class="note"> | |||
<p><strong>Note</strong>: Chrome always reports 60% of the actual disk size for privacy reasons.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p><strong>Note</strong>: Chrome always reports 60% of the actual disk size for privacy reasons.</p> | |
<p><strong>Note:</strong> User agents might not report the actual storage space for privacy reasons.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tryin to raise that the quota
may be larger than what is actually available to websites. This is confusing to developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would "User agents might not report the actual storage space for privacy reasons. Chrome, for instance, always reports 60% of the actual disk size." work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be much better, imo. If you happen to know if it is just "Chrome" or rather "Chromium-based browsers", then that would be good to be precise about, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be Chrome-specific according to GoogleChrome/web.dev#3896
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated PR. Let me know if that still looks good to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for making the changes and alerting web devs about it. Cheers 🎉
As noted in https://web.dev/storage-for-the-web/#:~:text=60%25%20of%20the%20actual%20disk%20size, Chrome always reports 60% of the actual disk size in the StorageManager API for privacy reasons.