Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the note less ambiguous #8912

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Make the note less ambiguous #8912

merged 1 commit into from
Sep 15, 2021

Conversation

SelenIT
Copy link
Contributor

@SelenIT SelenIT commented Sep 14, 2021

The specification actually doesn't require border-style and/or border-width for border-image to be rendered (w3c/csswg-drafts#655 (comment)). However, some browsers indeed would not render it without them (although this is technically a bug and is being fixed), so specifying them is a reasonable practical requirement at the moment (and providing fallbacks is a good practice anyway).

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'

What was wrong/why is this fix needed? (quick summary only)

Anything else that could help us review it

The specification actually doesn't _require_ `border-style` and/or `border-width` for `border-image` to be rendered (w3c/csswg-drafts#655 (comment)). However, some browsers indeed would not render it without them (although this is technically a bug and is being fixed), so specifying them is a reasonable practical requirement at the moment (and providing fallbacks is a good practice anyway).
@SelenIT SelenIT requested a review from a team as a code owner September 14, 2021 17:13
@SelenIT SelenIT requested review from rachelandrew and removed request for a team September 14, 2021 17:13
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/CSS/border-image
Title: border-image
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/conic-gradient() redirects to /en-US/docs/Web/CSS/gradient/conic-gradient()
    • /en-US/docs/Web/CSS/linear-gradient() redirects to /en-US/docs/Web/CSS/gradient/linear-gradient()
    • /en-US/docs/Web/CSS/repeating-linear-gradient() redirects to /en-US/docs/Web/CSS/gradient/repeating-linear-gradient()
    • /en-US/docs/Web/CSS/radial-gradient() redirects to /en-US/docs/Web/CSS/gradient/radial-gradient()
    • /en-US/docs/Web/CSS/repeating-radial-gradient() redirects to /en-US/docs/Web/CSS/gradient/repeating-radial-gradient()

External URLs

URL: /en-US/docs/Web/CSS/border-image
Title: border-image
on GitHub

No new external URLs

@sideshowbarker sideshowbarker added the Content:CSS Cascading Style Sheets docs label Sep 15, 2021
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rachelandrew rachelandrew merged commit 4984f95 into mdn:main Sep 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:CSS Cascading Style Sheets docs
3 participants