Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flex-shrinkのページの例にCSSが含まれていない #22086

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

k35o
Copy link
Contributor

@k35o k35o commented Jul 1, 2024

Description

https://developer.mozilla.org/ja/docs/Web/CSS/flex-shrink#%E4%BE%8B
にCSSが反映されていない

EmbedLiveSampleマクロの引数を見出しに合わせたものに変更してCSSを反映されるようにする

Motivation

flex-shrinkについてを説明した正しい例を確認してもらいたい!

Additional details

Related issues and pull requests

@k35o k35o requested a review from a team as a code owner July 1, 2024 03:05
@k35o k35o requested review from mfuji09 and removed request for a team July 1, 2024 03:05
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Jul 1, 2024
@k35o k35o changed the title flex-shrinkのページno Jul 1, 2024
@k35o k35o marked this pull request as draft July 1, 2024 03:06
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Preview URLs

Flaws (1)

URL: /ja/docs/Web/CSS/flex-shrink
Title: flex-shrink
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)
@k35o k35o marked this pull request as ready for review July 1, 2024 03:09
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです。

@mfuji09 mfuji09 merged commit 7abeab4 into mdn:main Jul 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ja Issues related to Japanese content.
2 participants