Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

段組みレイアウトのページにある段と断片化の例のhtmlが二重になっている #22088

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

k35o
Copy link
Contributor

@k35o k35o commented Jul 1, 2024

Description

https://developer.mozilla.org/ja/docs/Learn/CSS/CSS_layout/Multiple-column_Layout#%E6%AE%B5%E3%81%A8%E6%96%AD%E7%89%87%E5%8C%96
の例でHTMLが二重になっている。

https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Multiple-column_Layout#spanning_columns
英語版と同じようなヘディングの追加とEmbedLiveSampleマクロの引数を見出しに合わせたものに変更してCSSを反映されるようにする

Motivation

より綺麗で正しいサンプルを目指す

Additional details

Related issues and pull requests

@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Preview URLs

Flaws (40)

URL: /ja/docs/Learn/CSS/CSS_layout/Multiple-column_Layout
Title: 段組みレイアウト
Flaw count: 40

  • macros:
    • /ja/docs/Games/Publishing_games does not exist but fell back to /en-US/docs/Games/Publishing_games
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
    • and 34 more flaws omitted
  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

(comment last updated: 2024-07-02 08:42:24)

@k35o k35o marked this pull request as ready for review July 1, 2024 07:33
@k35o k35o requested a review from a team as a code owner July 1, 2024 07:33
@k35o k35o requested review from potappo and removed request for a team July 1, 2024 07:33
@k35o k35o marked this pull request as draft July 2, 2024 08:40
@k35o k35o marked this pull request as ready for review July 2, 2024 08:40
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです。

@mfuji09 mfuji09 merged commit 3686c0e into mdn:main Jul 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ja Issues related to Japanese content.
2 participants