Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] css doublecolon marker 번역 #22127

Merged
merged 2 commits into from
Jul 5, 2024
Merged

[ko] css doublecolon marker 번역 #22127

merged 2 commits into from
Jul 5, 2024

Conversation

givvemee
Copy link
Contributor

@givvemee givvemee commented Jul 3, 2024

Description

기존에 한국어로 존재하지 않던 문서 ::marker를 번역합니다.

Motivation

Additional details

Related issues and pull requests
@givvemee givvemee requested a review from a team as a code owner July 3, 2024 00:34
@givvemee givvemee requested review from 1ilsang and removed request for a team July 3, 2024 00:34
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Preview URLs

Flaws (5)

URL: /ko/docs/Web/CSS/::marker
Title: ::marker
Flaw count: 5

  • macros:
    • /ko/docs/Web/HTML/Element/summary does not exist but fell back to /en-US/docs/Web/HTML/Element/summary
    • /ko/docs/Web/CSS/text-combine-upright does not exist but fell back to /en-US/docs/Web/CSS/text-combine-upright
    • /ko/docs/Web/CSS/unicode-bidi does not exist but fell back to /en-US/docs/Web/CSS/unicode-bidi
    • /ko/docs/Web/CSS/direction does not exist but fell back to /en-US/docs/Web/CSS/direction
    • /ko/docs/Web/HTML/Element/summary does not exist but fell back to /en-US/docs/Web/HTML/Element/summary

(comment last updated: 2024-07-05 00:47:39)
1ilsang
1ilsang requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@givvemee 님 안녕하세요. 기여해주셔서 감사합니다! 💯

몇 가지 코멘트 남겨두었습니다.

확인하시고 다시 리뷰 요청 부탁드리겠습니다. 🙇

질문이나 도움이 필요하시다면 언제든 멘션 부탁드리겠습니다.
files/ko/web/css/_doublecolon_marker/index.md Outdated Show resolved Hide resolved
files/ko/web/css/_doublecolon_marker/index.md Outdated
## 같이 보기

- 마커 박스를 기본적으로 가지고 있는 HTML 요소들: {{HTMLElement("ol")}}, {{HTMLElement("li")}}, {{HTMLElement("summary")}}
- [CSS generated content](/ko/docs/Web/CSS/CSS_generated_content) 모듈
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [CSS generated content](/ko/docs/Web/CSS/CSS_generated_content) 모듈
- [CSS로 생성된 콘텐츠](/ko/docs/Web/CSS/CSS_generated_content) 모듈
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ilsang 리뷰 확인했습니다.
@givvemee givvemee requested a review from 1ilsang July 5, 2024 00:46
1ilsang
1ilsang approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨습니다
@1ilsang 1ilsang merged commit 24210a8 into mdn:main Jul 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
2 participants
@givvemee @1ilsang