Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve translation for ja in JS index #22155

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Improve translation for ja in JS index #22155

merged 1 commit into from
Jul 8, 2024

Conversation

okuramasafumi
Copy link
Contributor

Description

Improve translation for Japanese in JS index page.

Motivation

I noticed that the translation is partially wrong.

Additional details

Related issues and pull requests
@okuramasafumi
Improve translation for ja in JS index
10044c6 
The original phrase is "it's important to learn about them.", so 「学ぶことが重要」 is the correct translation.
@okuramasafumi okuramasafumi requested a review from a team as a code owner July 4, 2024 03:49
@okuramasafumi okuramasafumi requested review from mfuji09 and removed request for a team July 4, 2024 03:49
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Preview URLs

Flaws (39)

URL: /ja/docs/Learn/JavaScript
Title: JavaScript — 動的クライアントサイドスクリプト
Flaw count: 39

  • macros:
    • /ja/docs/Games/Publishing_games does not exist but fell back to /en-US/docs/Games/Publishing_games
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
    • and 34 more flaws omitted
mfuji09
mfuji09 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです。
@mfuji09 mfuji09 merged commit 89051ff into mdn:main Jul 8, 2024
6 checks passed
@okuramasafumi okuramasafumi deleted the patch-1 branch July 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ja Issues related to Japanese content.
2 participants
@okuramasafumi @mfuji09