Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: update the translation of CSS rgb() function #22177

Merged
merged 17 commits into from
Jul 13, 2024
Merged

[zh-cn]: update the translation of CSS rgb() function #22177

merged 17 commits into from
Jul 13, 2024

Conversation

linker-fen-js
Copy link
Contributor

Description

新增CSS RGB()函数中关于相对值的中文翻译描述，同时增加了一些例子

Motivation

相较于英文版，中文版缺失了关于相对值、from关键字的描述

Additional details

Related issues and pull requests
@linker-fen-js linker-fen-js requested a review from a team as a code owner July 5, 2024 23:16
@linker-fen-js linker-fen-js requested review from t7yang and removed request for a team July 5, 2024 23:16
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024 •
edited
Loading

Preview URLs

Flaws (2)

URL: /zh-CN/docs/Web/CSS/color_value/rgb
Title: rgb()
Flaw count: 2

  • macros:
    • /zh-CN/docs/Glossary/color_space does not exist but fell back to /en-US/docs/Glossary/Color_space
  • translation_differences:
    • Differences in the important macros (5 in common of 13 possible)

(comment last updated: 2024-07-13 12:15:15)
yin1999
yin1999 requested changes Jul 6, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在的翻译并未完全对应英文的文档内容（包括文本内容以及样式）。请仔细校对一下。关于标点的使用说明，请参考翻译指南
yin1999
yin1999 requested changes Jul 6, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我列举了几个常见的问题，下文中也有出现，请一一修正。并在修改完成后再将 PR 标记为“ready”。
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 marked this pull request as draft July 6, 2024 08:07
@linker-fen-js
Copy link
Contributor Author

现在的翻译并未完全对应英文的文档内容（包括文本内容以及样式）。请仔细校对一下。关于标点的使用说���，请参考翻译指南

我刚才重新修改了一些文本内容和样式，但git bot还是显示 “Please fix all the linting issues mentioned in above logs and in the review comments.”，我该如何查看具体哪一行文本导致了自动检查失败
@linker-fen-js linker-fen-js marked this pull request as ready for review July 6, 2024 10:33
@yin1999 yin1999 changed the title [zh-cn]: update the translation of CSS RGB() Jul 6, 2024
yin1999
yin1999 reviewed Jul 6, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还请再仔细检查一下内容，有些空格和样式是不需要的（注意括号、逗号等标点前后的空格）
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
@linker-fen-js linker-fen-js marked this pull request as draft July 6, 2024 16:42
@linker-fen-js linker-fen-js marked this pull request as ready for review July 6, 2024 16:59
@yin1999 yin1999 changed the title [zh-cn]: update the translation of CSS rgb() function Jul 7, 2024
yin1999
yin1999 requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们并不赞同按自己的想法去翻译内容的做法，因为这会为我们的文档维护工作带来很多困难。请解决我提到的所有问题。然后再将此 PR 标记为“ready”
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Show resolved Hide resolved
@yin1999 yin1999 marked this pull request as draft July 7, 2024 06:16
github-actions[bot]
github-actions bot reviewed Jul 7, 2024
View reviewed changes
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
@linker-fen-js linker-fen-js marked this pull request as ready for review July 7, 2024 20:23
yin1999
yin1999 approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@yin1999 yin1999 merged commit 246ed80 into mdn:main Jul 13, 2024
7 checks passed
@yin1999 yin1999 mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
3 participants
@linker-fen-js @yin1999 @skyclouds2001