Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Intl.Segmenter 설명 신규 번역 외 #22309

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

wisedog
Copy link
Contributor

@wisedog wisedog commented Jul 7, 2024

  • Intl.Segmenter 설명 신규 번역
  • Array.length 최신화
- Intl.Segmenter 설명 신규 번역
- Array.length 최신화
@wisedog wisedog requested a review from a team as a code owner July 7, 2024 23:10
@wisedog wisedog requested review from 1ilsang and removed request for a team July 7, 2024 23:10
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 7, 2024
Copy link
Contributor

github-actions bot commented Jul 7, 2024

Preview URLs

Flaws (5)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter
Title: Intl.Segmenter
Flaw count: 5

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/Segmenter does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/Segmenter
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/supportedLocalesOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/supportedLocalesOf
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/Segmenter does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/Segmenter
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/resolvedOptions does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/resolvedOptions
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/segment does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/segment

(comment last updated: 2024-07-09 13:19:06)

Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wisedog 님 안녕하세요. 기여해주셔서 감사합니다! 💯

몇 가지 코멘트 남겨두었습니다.

확인하시고 다시 리뷰 요청 부탁드리겠습니다. 🙇

질문이나 도움이 필요하시다면 언제든 멘션 부탁드리겠습니다.


### 고정 길이의 빈 배열 생성하기

`length`를 현재 크기보다 더 크게 설정하면 [회소 배열](/ko/docs/Web/JavaScript/Guide/Indexed_collections#희소_배열)을 생성합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`length`를 현재 크기보다 더 크게 설정하면 [회소 배열](/ko/docs/Web/JavaScript/Guide/Indexed_collections#희소_배열)을 생성합니다.
`length`를 현재 크기보다 더 크게 설정하면 [희소 배열](/ko/docs/Web/JavaScript/Guide/Indexed_collections#희소_배열)을 생성합니다.

오타로 보입니다. 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아.... 🤦‍♂️

Comment on lines 29 to 31
- 인��턴스 객체를 생성한 생성자 함수입니다. `Intl.Segmenter` 인스턴스의 경우, 초기 값은 {{jsxref("Intl/Segmenter/Segmenter", "Intl.Segmenter")}} 생성자입니다.
- `Intl.Segmenter.prototype[@@toStringTag]`
- [`@@toStringTag`](/ko/docs/Web/JavaScript/Reference/Global_Objects/Symbol/toStringTag) 속성의 초기 값은 문자열 `"Intl.Segmenter"`입니다. 이 속성은 {{jsxref("Object.prototype.toString()")}}에서 사용됩니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 인스턴스 객체를 생성한 생성자 함수입니다. `Intl.Segmenter` 인스턴스의 경우, 초기 값은 {{jsxref("Intl/Segmenter/Segmenter", "Intl.Segmenter")}} 생성자입니다.
- `Intl.Segmenter.prototype[@@toStringTag]`
- [`@@toStringTag`](/ko/docs/Web/JavaScript/Reference/Global_Objects/Symbol/toStringTag) 속성의 초기 값은 문자열 `"Intl.Segmenter"`입니다. 이 속성은 {{jsxref("Object.prototype.toString()")}}에서 사용됩니다.
- : 인스턴스 객체를 생성한 생성자 함수입니다. `Intl.Segmenter` 인스턴스의 경우, 초기 값은 {{jsxref("Intl/Segmenter/Segmenter", "Intl.Segmenter")}} 생성자입니다.
- `Intl.Segmenter.prototype[@@toStringTag]`
- : [`@@toStringTag`](/ko/docs/Web/JavaScript/Reference/Global_Objects/Symbol/toStringTag) 속성의 초기 값은 문자열 `"Intl.Segmenter"`입니다. 이 속성은 {{jsxref("Object.prototype.toString()")}}에서 사용됩니다.

원문과 동일한 형태를 유지해 주세요.

const str = "吾輩は猫である。名前はたぬき。";
console.table(str.split(" "));
// ['吾輩は猫である。名前はたぬき。']
// The two sentences are not correctly segmented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The two sentences are not correctly segmented.
// 두 문장이 올바르게 분할되지 않았습니다.
const segments = segmenterJa.segment(str);
console.table(Array.from(segments));
// [{segment: '吾輩', index: 0, input: '吾輩は猫である。名前はたぬき。', isWordLike: true},
// etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// etc.
// 기타 등등
@wisedog wisedog requested a review from 1ilsang July 9, 2024 13:12
@wisedog
Copy link
Contributor Author

wisedog commented Jul 9, 2024

@1ilsang 리뷰 감사합니다. 수정했으니 다시 확인 부탁드립니다.

Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨습니다~!

@1ilsang 1ilsang merged commit c19cf79 into mdn:main Jul 10, 2024
7 checks passed
@wisedog wisedog deleted the js/intl-segmenter branch July 10, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
2 participants