Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-CN] create some media-related docs #22312

Merged
merged 29 commits into from
Jul 13, 2024
Merged

[zh-CN] create some media-related docs #22312

merged 29 commits into from
Jul 13, 2024

Conversation

IvanHanloth
Copy link
Contributor

@IvanHanloth IvanHanloth commented Jul 8, 2024

Create translation for Web/API/BaseAudioContext/audioWorklet
Create Web/API/HTMLMediaElement/defaultMuted
Update and complete Web/API/HTMLMediaElement/readyState

@IvanHanloth IvanHanloth requested a review from a team as a code owner July 8, 2024 01:28
@IvanHanloth IvanHanloth requested review from t7yang and removed request for a team July 8, 2024 01:28
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Preview URLs

Flaws (3)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/API/BaseAudioContext/audioWorklet
Title: BaseAudioContext:audioWorklet 属性
Flaw count: 3

  • macros:
    • /zh-CN/docs/Web/API/BaseAudioContext does not exist but fell back to /en-US/docs/Web/API/BaseAudioContext
    • /zh-CN/docs/Web/API/AudioWorklet does not exist but fell back to /en-US/docs/Web/API/AudioWorklet
    • /zh-CN/docs/Web/API/AudioWorklet does not exist but fell back to /en-US/docs/Web/API/AudioWorklet

(comment last updated: 2024-07-13 04:19:16)

IvanHanloth and others added 2 commits July 8, 2024 09:36
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些建议

IvanHanloth and others added 4 commits July 8, 2024 16:28
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yin1999
Copy link
Member

yin1999 commented Jul 12, 2024

@IvanHanloth 请注意,下次尽量不要在审查人员对 PR 进行审查后再添加新的文档的修改。如果你想对其他文档做出贡献,请创建新的分支

@IvanHanloth
Copy link
Contributor Author

@IvanHanloth 请注意,下次尽量不要在审查人员对 PR 进行审查后再添加新的文档的修改。如果你想对其他文档做出贡献,请创建新的分支
收到,之前提交的时候忽略了

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻译并不够准确(意思还是尽可能贴近原文),例如:

{{domxref("HTMLMediaElement")}}:用于定义 `HTMLMediaElement.defaultMuted` 属性的接口

如果只写“用于指定 xxx 属性”,那是没法表明它是一个接口。

files/zh-cn/web/api/htmlmediaelement/defaultmuted/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/defaultmuted/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/defaultmuted/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/readystate/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/readystate/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/readystate/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/readystate/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/readystate/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/readystate/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/htmlmediaelement/readystate/index.md Outdated Show resolved Hide resolved
IvanHanloth and others added 7 commits July 13, 2024 12:13
Co-authored-by: A1lo <yin199909@aliyun.com>
Co-authored-by: A1lo <yin199909@aliyun.com>
Co-authored-by: A1lo <yin199909@aliyun.com>
Co-authored-by: A1lo <yin199909@aliyun.com>
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 @IvanHanloth 🙏

@yin1999 yin1999 enabled auto-merge (squash) July 13, 2024 05:33
@yin1999 yin1999 disabled auto-merge July 13, 2024 05:33
@yin1999 yin1999 changed the title [zh-CN] create Web/API/BaseAudioContext/audioWorklet Jul 13, 2024
@yin1999 yin1999 merged commit ee69383 into mdn:main Jul 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
2 participants