Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module: es2022 #44656

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Add module: es2022 #44656

merged 1 commit into from
Sep 30, 2021

Conversation

saschanaz
Copy link
Contributor

Closes #44653
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 18, 2021
saschanaz
saschanaz commented Jun 18, 2021
View reviewed changes
src/testRunner/unittests/config/convertCompilerOptionsFromJson.ts
@@ -184,7 +184,7 @@ namespace ts {
file: undefined,
start: 0,
length: 0,
messageText: "Argument for '--module' option must be: 'none', 'commonjs', 'amd', 'system', 'umd', 'es6', 'es2015', 'esnext'.",
messageText: "Argument for '--module' option must be: 'none', 'commonjs', 'amd', 'system', 'umd', 'es6', 'es2015', 'es2020', 'es2022', 'esnext'.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting to see this hasn't failed. I don't think this even runs 🤔
@saschanaz
Copy link
Contributor Author

saschanaz commented Jun 18, 2021 •
edited
Loading

Should this function return ModuleKind.ES2020 and ES2022 following the target version? It seems #33893 missed this, and I wonder this needs to be fixed.

TypeScript/src/compiler/utilities.ts

Lines 6035 to 6039 in 5afe42e

export function getEmitModuleKind(compilerOptions: {module?: CompilerOptions["module"], target?: CompilerOptions["target"]}) {
return typeof compilerOptions.module === "number" ?
compilerOptions.module :
getEmitScriptTarget(compilerOptions) >= ScriptTarget.ES2015 ? ModuleKind.ES2015 : ModuleKind.CommonJS;
}

@sandersn sandersn added this to Not started in PR Backlog Jul 2, 2021
@typescript-bot typescript-bot removed the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 2, 2021
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 2, 2021
@sandersn sandersn moved this from Not started to Needs review in PR Backlog Jul 2, 2021
@orta orta mentioned this pull request Sep 2, 2021
Closed
@MartinJohns
Copy link
Contributor

PR seems kind of outdated.
@saschanaz
Copy link
Contributor Author

saschanaz commented Sep 25, 2021 •
edited
Loading

I'll rebase once anyone reviews this (or a maintainer requests a rebase).
@weswigham
Copy link
Member

This is going to look a weeee bit different after a merge since the module: node changes touch many of the same lines, but initially it looks ok.
@simllll
Copy link
Contributor

simllll commented Sep 28, 2021 •
edited
Loading

Next to module: node12, this is another thing I'm really looking forward to. Currently there is no real setting for node 16 environment, see also https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
weswigham
weswigham approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This little looks fine to me - @DanielRosenwasser do we want this in for the beta?
PR Backlog automation moved this from Waiting on reviewers to Needs merge Sep 29, 2021
DanielRosenwasser
DanielRosenwasser approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this seems reasonable.
@DanielRosenwasser DanielRosenwasser merged commit 2161e18 into microsoft:main Sep 30, 2021
PR Backlog automation moved this from Needs merge to Done Sep 30, 2021
@saschanaz saschanaz deleted the es2022 branch September 30, 2021 10:53
@saschanaz saschanaz mentioned this pull request Sep 30, 2021
Open
@standiki
Copy link

What could be the default option for this and the highest version, I guess is none and esnext?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
7 participants
@saschanaz @MartinJohns @weswigham @simllll @standiki @DanielRosenwasser @typescript-bot