Support export type *

[andrewbranch]

Fixes #37238

Adds support for export type * from "mod" and export type * as ns from "mod".

[andrewbranch]

@typescript-bot perf test this
@typescript-bot test top100

[typescript-bot]

Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at 08701ac. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @andrewbranch, I've started to run the perf test suite on this PR at 08701ac. You can monitor the build here.

Update: The results are in!

[jakebailey]

I can't say I saw anything surprising in the checker (looked as I would guess), but I think the baselines say it all and look good to me; all of the edge cases I was coming up with appear to be tested.

[typescript-bot]

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52217

Metric	main	52217	Delta	Best	Worst
Angular - node (v18.10.0, x64)
Memory used	361,163k (± 0.01%)	361,169k (± 0.01%)	+6k (+ 0.00%)	361,117k	361,213k
Parse Time	3.94s (± 1.12%)	3.93s (± 0.74%)	-0.01s (- 0.34%)	3.89s	3.98s
Bind Time	1.21s (± 0.56%)	1.21s (± 0.33%)	+0.00s (+ 0.00%)	1.21s	1.22s
Check Time	8.78s (± 0.55%)	8.77s (± 0.54%)	-0.01s (- 0.09%)	8.70s	8.84s
Emit Time	7.48s (± 0.41%)	7.49s (± 0.56%)	+0.00s (+ 0.04%)	7.43s	7.54s
Total Time	21.42s (± 0.29%)	21.39s (± 0.29%)	-0.02s (- 0.10%)	21.35s	21.52s
Compiler-Unions - node (v18.10.0, x64)
Memory used	193,036k (± 1.25%)	192,040k (± 0.12%)	-996k (- 0.52%)	191,743k	192,272k
Parse Time	1.66s (± 0.76%)	1.64s (± 1.21%)	-0.02s (- 1.40%)	1.61s	1.66s
Bind Time	0.80s (± 0.91%)	0.80s (± 0.61%)	+0.00s (+ 0.41%)	0.80s	0.81s
Check Time	9.57s (± 0.73%)	9.55s (± 0.40%)	-0.02s (- 0.22%)	9.51s	9.62s
Emit Time	2.89s (± 5.20%)	2.88s (± 5.94%)	-0.01s (- 0.26%)	2.75s	3.12s
Total Time	14.93s (± 1.02%)	14.88s (± 1.23%)	-0.05s (- 0.35%)	14.73s	15.15s
Monaco - node (v18.10.0, x64)
Memory used	345,704k (± 0.01%)	345,740k (± 0.01%)	+36k (+ 0.01%)	345,680k	345,794k
Parse Time	2.91s (± 0.51%)	2.90s (± 0.56%)	-0.01s (- 0.46%)	2.88s	2.92s
Bind Time	1.06s (± 1.13%)	1.05s (± 0.54%)	-0.00s (- 0.16%)	1.05s	1.06s
Check Time	7.23s (± 0.33%)	7.25s (± 0.45%)	+0.02s (+ 0.23%)	7.20s	7.28s
Emit Time	4.31s (± 0.51%)	4.31s (± 1.31%)	-0.00s (- 0.12%)	4.24s	4.40s
Total Time	15.52s (± 0.13%)	15.52s (± 0.64%)	-0.00s (- 0.02%)	15.41s	15.65s
TFS - node (v18.10.0, x64)
Memory used	300,525k (± 0.00%)	300,513k (± 0.01%)	-12k (- 0.00%)	300,488k	300,536k
Parse Time	2.24s (± 1.30%)	2.24s (± 1.49%)	+0.00s (+ 0.10%)	2.19s	2.28s
Bind Time	1.17s (± 0.58%)	1.18s (± 0.52%)	+0.01s (+ 0.81%)	1.18s	1.19s
Check Time	6.83s (± 0.26%)	6.84s (± 0.36%)	+0.02s (+ 0.22%)	6.80s	6.87s
Emit Time	3.94s (± 0.59%)	3.94s (± 0.80%)	-0.00s (- 0.07%)	3.90s	3.99s
Total Time	14.18s (± 0.36%)	14.21s (± 0.34%)	+0.02s (+ 0.17%)	14.12s	14.25s
material-ui - node (v18.10.0, x64)
Memory used	476,358k (± 0.01%)	476,424k (± 0.02%)	+66k (+ 0.01%)	476,303k	476,532k
Parse Time	3.49s (± 0.31%)	3.48s (± 1.73%)	-0.01s (- 0.36%)	3.39s	3.54s
Bind Time	0.98s (± 0.38%)	1.00s (± 2.71%)	+0.02s (+ 1.94%)	0.97s	1.05s
Check Time	16.98s (± 0.71%)	17.05s (± 0.47%)	+0.06s (+ 0.38%)	16.98s	17.20s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	21.45s (± 0.54%)	21.52s (± 0.40%)	+0.07s (+ 0.34%)	21.42s	21.67s
xstate - node (v18.10.0, x64)
Memory used	546,273k (± 0.01%)	546,312k (± 0.03%)	+39k (+ 0.01%)	546,167k	546,617k
Parse Time	4.38s (± 1.14%)	4.38s (± 0.86%)	+0.00s (+ 0.06%)	4.32s	4.42s
Bind Time	1.71s (± 0.88%)	1.70s (± 0.49%)	-0.01s (- 0.35%)	1.69s	1.71s
Check Time	2.72s (± 0.36%)	2.71s (± 0.51%)	-0.01s (- 0.48%)	2.68s	2.72s
Emit Time	0.08s (± 0.23%)	0.08s (± 5.05%)	+0.00s (+ 2.22%)	0.08s	0.09s
Total Time	8.89s (± 0.68%)	8.87s (± 0.57%)	-0.01s (- 0.15%)	8.78s	8.93s
Angular - node (v16.17.1, x64)
Memory used	360,570k (± 0.02%)	360,574k (± 0.01%)	+5k (+ 0.00%)	360,505k	360,642k
Parse Time	4.14s (± 0.33%)	4.13s (± 0.34%)	-0.01s (- 0.33%)	4.11s	4.15s
Bind Time	1.27s (± 0.36%)	1.28s (± 0.29%)	+0.00s (+ 0.20%)	1.27s	1.28s
Check Time	9.42s (± 0.30%)	9.43s (± 0.52%)	+0.01s (+ 0.10%)	9.37s	9.50s
Emit Time	7.95s (± 0.49%)	7.98s (± 0.56%)	+0.03s (+ 0.36%)	7.92s	8.05s
Total Time	22.78s (± 0.30%)	22.81s (± 0.41%)	+0.03s (+ 0.12%)	22.69s	22.95s
Compiler-Unions - node (v16.17.1, x64)
Memory used	195,601k (± 1.02%)	194,939k (± 0.99%)	-662k (- 0.34%)	193,531k	197,506k
Parse Time	1.80s (± 0.85%)	1.82s (± 1.15%)	+0.03s (+ 1.49%)	1.80s	1.86s
Bind Time	0.85s (± 0.49%)	0.85s (± 0.38%)	-0.00s (- 0.29%)	0.84s	0.85s
Check Time	10.24s (± 0.68%)	10.28s (± 0.69%)	+0.04s (+ 0.38%)	10.20s	10.41s
Emit Time	3.08s (± 4.23%)	3.16s (± 5.33%)	+0.08s (+ 2.59%)	2.99s	3.37s
Total Time	15.97s (± 0.91%)	16.11s (± 1.02%)	+0.14s (+ 0.88%)	15.92s	16.32s
Monaco - node (v16.17.1, x64)
Memory used	345,089k (± 0.01%)	345,148k (± 0.00%)	+60k (+ 0.02%)	345,125k	345,162k
Parse Time	3.09s (± 0.69%)	3.10s (± 0.42%)	+0.01s (+ 0.32%)	3.08s	3.11s
Bind Time	1.11s (± 1.35%)	1.11s (± 1.28%)	-0.00s (- 0.35%)	1.09s	1.13s
Check Time	7.87s (± 0.45%)	7.89s (± 0.29%)	+0.02s (+ 0.31%)	7.86s	7.92s
Emit Time	4.54s (± 0.71%)	4.55s (± 0.79%)	+0.02s (+ 0.36%)	4.52s	4.62s
Total Time	16.60s (± 0.32%)	16.64s (± 0.39%)	+0.04s (+ 0.25%)	16.59s	16.76s
TFS - node (v16.17.1, x64)
Memory used	299,892k (± 0.00%)	299,890k (± 0.01%)	-3k (- 0.00%)	299,859k	299,916k
Parse Time	2.44s (± 1.56%)	2.41s (± 0.25%)	-0.03s (- 1.22%)	2.41s	2.42s
Bind Time	1.27s (± 0.67%)	1.26s (± 1.33%)	-0.00s (- 0.32%)	1.24s	1.29s
Check Time	7.41s (± 0.41%)	7.42s (± 0.34%)	+0.01s (+ 0.13%)	7.38s	7.44s
Emit Time	4.25s (± 0.59%)	4.23s (± 0.82%)	-0.02s (- 0.48%)	4.18s	4.28s
Total Time	15.36s (± 0.31%)	15.31s (± 0.40%)	-0.05s (- 0.31%)	15.26s	15.42s
material-ui - node (v16.17.1, x64)
Memory used	475,630k (± 0.01%)	475,696k (± 0.01%)	+66k (+ 0.01%)	475,663k	475,739k
Parse Time	3.66s (± 0.33%)	3.65s (± 0.35%)	-0.00s (- 0.03%)	3.65s	3.68s
Bind Time	1.02s (± 0.85%)	1.02s (± 0.48%)	-0.00s (- 0.03%)	1.02s	1.03s
Check Time	18.01s (± 1.47%)	17.92s (± 0.33%)	-0.10s (- 0.53%)	17.82s	18.00s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	22.69s (± 1.17%)	22.59s (± 0.27%)	-0.09s (- 0.41%)	22.50s	22.68s
xstate - node (v16.17.1, x64)
Memory used	543,815k (± 0.01%)	543,890k (± 0.02%)	+75k (+ 0.01%)	543,824k	544,068k
Parse Time	4.56s (± 0.40%)	4.56s (± 0.30%)	-0.00s (- 0.10%)	4.53s	4.57s
Bind Time	1.79s (± 0.62%)	1.78s (± 0.75%)	-0.01s (- 0.65%)	1.76s	1.80s
Check Time	2.93s (± 0.43%)	2.93s (± 0.35%)	+0.00s (+ 0.13%)	2.92s	2.95s
Emit Time	0.08s (± 0.21%)	0.08s (± 5.09%)	+0.00s (+ 1.99%)	0.08s	0.09s
Total Time	9.37s (± 0.32%)	9.36s (± 0.28%)	-0.00s (- 0.05%)	9.33s	9.41s
Angular - node (v14.15.1, x64)
Memory used	354,205k (± 0.01%)	354,209k (± 0.00%)	+4k (+ 0.00%)	354,187k	354,224k
Parse Time	4.17s (± 0.48%)	4.16s (± 0.63%)	-0.00s (- 0.04%)	4.12s	4.20s
Bind Time	1.30s (± 0.56%)	1.30s (± 1.28%)	+0.01s (+ 0.39%)	1.29s	1.33s
Check Time	9.75s (± 0.40%)	9.77s (± 0.48%)	+0.02s (+ 0.22%)	9.72s	9.85s
Emit Time	8.30s (± 0.87%)	8.27s (± 0.63%)	-0.03s (- 0.38%)	8.21s	8.35s
Total Time	23.52s (± 0.40%)	23.51s (± 0.46%)	-0.01s (- 0.05%)	23.39s	23.71s
Compiler-Unions - node (v14.15.1, x64)
Memory used	188,945k (± 0.02%)	188,962k (± 0.02%)	+17k (+ 0.01%)	188,922k	189,023k
Parse Time	1.83s (± 0.58%)	1.83s (± 0.63%)	-0.00s (- 0.08%)	1.82s	1.85s
Bind Time	0.88s (± 1.15%)	0.88s (± 0.48%)	-0.00s (- 0.28%)	0.87s	0.88s
Check Time	10.26s (± 0.53%)	10.30s (± 0.67%)	+0.05s (+ 0.47%)	10.21s	10.39s
Emit Time	3.15s (± 0.61%)	3.13s (± 0.88%)	-0.02s (- 0.48%)	3.10s	3.17s
Total Time	16.12s (± 0.49%)	16.14s (± 0.65%)	+0.02s (+ 0.15%)	15.99s	16.28s
Monaco - node (v14.15.1, x64)
Memory used	339,885k (± 0.02%)	339,855k (± 0.00%)	-30k (- 0.01%)	339,836k	339,870k
Parse Time	3.22s (± 1.23%)	3.23s (± 0.34%)	+0.00s (+ 0.10%)	3.21s	3.24s
Bind Time	1.14s (± 0.98%)	1.14s (± 0.57%)	-0.00s (- 0.05%)	1.12s	1.14s
Check Time	8.16s (± 0.53%)	8.19s (± 0.33%)	+0.03s (+ 0.36%)	8.14s	8.21s
Emit Time	4.79s (± 0.57%)	4.77s (± 0.78%)	-0.02s (- 0.35%)	4.73s	4.82s
Total Time	17.30s (± 0.45%)	17.32s (± 0.31%)	+0.01s (+ 0.07%)	17.23s	17.36s
TFS - node (v14.15.1, x64)
Memory used	294,787k (± 0.00%)	294,789k (± 0.00%)	+2k (+ 0.00%)	294,782k	294,799k
Parse Time	2.70s (± 0.93%)	2.72s (± 1.30%)	+0.02s (+ 0.60%)	2.67s	2.76s
Bind Time	1.11s (± 0.44%)	1.11s (± 0.81%)	-0.00s (- 0.28%)	1.09s	1.11s
Check Time	7.73s (± 0.45%)	7.72s (± 0.45%)	-0.01s (- 0.09%)	7.68s	7.77s
Emit Time	4.58s (± 1.00%)	4.58s (± 0.64%)	-0.00s (- 0.02%)	4.53s	4.61s
Total Time	16.12s (± 0.56%)	16.12s (± 0.49%)	+0.00s (+ 0.02%)	16.02s	16.26s
material-ui - node (v14.15.1, x64)
Memory used	471,142k (± 0.00%)	471,170k (± 0.00%)	+28k (+ 0.01%)	471,160k	471,186k
Parse Time	3.82s (± 0.42%)	3.83s (± 0.98%)	+0.01s (+ 0.35%)	3.79s	3.90s
Bind Time	1.03s (± 0.59%)	1.03s (± 0.91%)	+0.00s (+ 0.35%)	1.02s	1.05s
Check Time	18.91s (± 0.58%)	18.91s (± 0.68%)	-0.00s (- 0.02%)	18.71s	19.09s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	23.76s (± 0.45%)	23.78s (± 0.66%)	+0.02s (+ 0.09%)	23.59s	24.04s
xstate - node (v14.15.1, x64)
Memory used	532,069k (± 0.01%)	532,080k (± 0.01%)	+12k (+ 0.00%)	532,046k	532,143k
Parse Time	4.96s (± 0.94%)	4.98s (± 0.80%)	+0.02s (+ 0.40%)	4.93s	5.03s
Bind Time	1.66s (± 0.78%)	1.66s (± 0.66%)	-0.00s (- 0.03%)	1.65s	1.68s
Check Time	3.06s (± 0.40%)	3.07s (± 0.39%)	+0.01s (+ 0.44%)	3.06s	3.09s
Emit Time	0.10s (± 0.18%)	0.10s (± 4.03%)	+0.00s (+ 1.84%)	0.10s	0.11s
Total Time	9.79s (± 0.52%)	9.82s (± 0.59%)	+0.03s (+ 0.34%)	9.75s	9.92s

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52217	6
Baseline	main	6

TSServer

Comparison Report - main..52217

Metric	main	52217	Delta	Best	Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,434ms (± 7.59%)	2,387ms (± 7.54%)	-46ms (- 1.90%)	2,150ms	2,567ms
Req 2 - geterr	5,175ms (± 6.86%)	5,094ms (± 7.51%)	-81ms (- 1.57%)	4,733ms	5,554ms
Req 3 - references	360ms (± 7.22%)	351ms (± 9.09%)	-9ms (- 2.56%)	318ms	381ms
Req 4 - navto	274ms (± 7.45%)	269ms (± 7.97%)	-4ms (- 1.51%)	243ms	296ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	134ms (±75.71%)	67ms (± 7.91%)	🟩-68ms (-50.45%)	61ms	74ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,712ms (± 1.31%)	2,681ms (± 1.57%)	-32ms (- 1.17%)	2,640ms	2,747ms
Req 2 - geterr	3,977ms (± 0.54%)	3,976ms (± 0.46%)	-1ms (- 0.03%)	3,955ms	4,005ms
Req 3 - references	374ms (± 0.77%)	375ms (± 0.57%)	+1ms (+ 0.35%)	372ms	377ms
Req 4 - navto	290ms (± 0.39%)	291ms (± 0.81%)	+1ms (+ 0.35%)	287ms	294ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	82ms (± 2.54%)	82ms (± 3.46%)	-0ms (- 0.04%)	77ms	84ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,364ms (± 0.78%)	3,364ms (± 0.68%)	-0ms (- 0.00%)	3,321ms	3,384ms
Req 2 - geterr	1,398ms (± 0.67%)	1,398ms (± 1.13%)	-0ms (- 0.02%)	1,380ms	1,422ms
Req 3 - references	250ms (± 1.26%)	251ms (± 0.98%)	+1ms (+ 0.34%)	247ms	253ms
Req 4 - navto	359ms (± 0.74%)	359ms (± 0.74%)	+0ms (+ 0.02%)	356ms	362ms
Req 5 - completionInfo count	3,154 (± 0.00%)	3,154 (± 0.00%)	0 ( 0.00%)	3,154	3,154
Req 5 - completionInfo	439ms (± 2.01%)	442ms (± 1.89%)	+3ms (+ 0.76%)	427ms	451ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,759ms (± 0.62%)	2,689ms (± 5.18%)	-70ms (- 2.53%)	2,408ms	2,768ms
Req 2 - geterr	5,795ms (± 0.50%)	5,673ms (± 5.54%)	-122ms (- 2.10%)	5,033ms	5,838ms
Req 3 - references	376ms (± 0.83%)	366ms (± 5.37%)	-10ms (- 2.58%)	326ms	376ms
Req 4 - navto	275ms (± 0.89%)	268ms (± 5.87%)	-7ms (- 2.68%)	236ms	278ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	301ms (± 1.22%)	292ms (± 4.63%)	🟩-9ms (- 3.03%)	265ms	301ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,864ms (± 0.33%)	2,866ms (± 0.78%)	+2ms (+ 0.07%)	2,840ms	2,902ms
Req 2 - geterr	4,321ms (± 0.31%)	4,291ms (± 0.38%)	-30ms (- 0.69%)	4,269ms	4,313ms
Req 3 - references	386ms (± 1.69%)	390ms (± 0.67%)	+4ms (+ 1.03%)	386ms	394ms
Req 4 - navto	300ms (± 0.33%)	298ms (± 0.59%)	-1ms (- 0.40%)	296ms	301ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	79ms (± 0.66%)	80ms (± 1.95%)	+0ms (+ 0.59%)	78ms	82ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,473ms (± 0.50%)	3,474ms (± 0.50%)	+0ms (+ 0.01%)	3,452ms	3,500ms
Req 2 - geterr	1,639ms (± 5.04%)	1,663ms (± 4.04%)	+24ms (+ 1.47%)	1,526ms	1,699ms
Req 3 - references	166ms (±53.85%)	141ms (±49.66%)	🟩-24ms (-14.69%)	109ms	284ms
Req 4 - navto	339ms (± 2.57%)	336ms (± 1.90%)	-3ms (- 0.84%)	327ms	346ms
Req 5 - completionInfo count	3,154 (± 0.00%)	3,154 (± 0.00%)	0 ( 0.00%)	3,154	3,154
Req 5 - completionInfo	480ms (± 1.42%)	484ms (± 1.10%)	+4ms (+ 0.83%)	479ms	494ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,857ms (± 0.52%)	2,853ms (± 0.74%)	-4ms (- 0.13%)	2,819ms	2,880ms
Req 2 - geterr	6,210ms (± 1.26%)	6,179ms (± 0.69%)	-31ms (- 0.51%)	6,130ms	6,245ms
Req 3 - references	388ms (± 1.28%)	389ms (± 0.39%)	+1ms (+ 0.30%)	387ms	391ms
Req 4 - navto	288ms (± 1.02%)	285ms (± 0.37%)	-3ms (- 1.07%)	284ms	287ms
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	0 ( 0.00%)	1,356	1,356
Req 5 - completionInfo	88ms (± 7.23%)	83ms (± 8.95%)	🟩-5ms (- 5.56%)	74ms	92ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,010ms (± 1.07%)	3,031ms (± 1.23%)	+21ms (+ 0.70%)	2,981ms	3,071ms
Req 2 - geterr	4,585ms (± 0.34%)	4,612ms (± 0.59%)	+26ms (+ 0.57%)	4,584ms	4,653ms
Req 3 - references	413ms (± 0.59%)	412ms (± 1.15%)	-2ms (- 0.37%)	404ms	416ms
Req 4 - navto	307ms (± 0.57%)	306ms (± 1.05%)	-0ms (- 0.06%)	301ms	310ms
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	0 ( 0.00%)	1,518	1,518
Req 5 - completionInfo	78ms (± 0.37%)	78ms (± 1.46%)	+0ms (+ 0.26%)	78ms	81ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,805ms (± 0.46%)	3,812ms (± 0.56%)	+7ms (+ 0.19%)	3,789ms	3,841ms
Req 2 - geterr	1,476ms (± 1.10%)	1,478ms (± 0.80%)	+1ms (+ 0.10%)	1,462ms	1,490ms
Req 3 - references	128ms (± 2.08%)	132ms (± 1.47%)	+3ms (+ 2.63%)	130ms	134ms
Req 4 - navto	387ms (± 0.73%)	390ms (± 1.06%)	+3ms (+ 0.76%)	387ms	398ms
Req 5 - completionInfo count	3,154 (± 0.00%)	3,154 (± 0.00%)	0 ( 0.00%)	3,154	3,154
Req 5 - completionInfo	497ms (± 1.35%)	497ms (± 1.49%)	-0ms (- 0.02%)	484ms	505ms

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52217	6
Baseline	main	6

Startup

Comparison Report - main..52217

Metric	main	52217	Delta	Best	Worst
tsc-startup - node (v16.17.1, x64)
Execution time	139.64ms (± 0.18%)	139.63ms (± 0.22%)	-0.01ms (- 0.00%)	138.67ms	143.08ms
tsserver-startup - node (v16.17.1, x64)
Execution time	231.84ms (± 0.22%)	232.12ms (± 0.18%)	+0.28ms (+ 0.12%)	230.78ms	237.57ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	234.25ms (± 0.19%)	234.27ms (± 0.20%)	+0.02ms (+ 0.01%)	232.83ms	240.29ms
typescript-startup - node (v16.17.1, x64)
Execution time	216.40ms (± 0.26%)	215.96ms (± 0.19%)	-0.44ms (- 0.20%)	214.37ms	220.07ms

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	52217	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/52217/merge:

Everything looks good!

[andrewbranch]

@typescript-bot pack this

[typescript-bot]

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 3b6a185. You can monitor the build here.

[typescript-bot]

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/142506/artifacts?artifactName=tgz&fileId=1BF16492D581EC4BF36216D73ACECB3D69DB03FD7F42EEBC4330F0C00F7BE01702&fileName=/typescript-5.0.0-insiders.20230113.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52217-7".;

[weswigham]

Unless I'm mistaken, it looks like this needs some (error-free) .d.ts emit tests to ensure we preserve the export typey-ness of these declarations when doing declaration emit (and probably some emitter/declaration emitter code to match). A test with an export type declaration in a js file with js declaration emit on would also be relevant, despite (I assume) being an error.

[andrewbranch]

Good call. I suspect it already works since this form is not actually new syntax, just newly not a grammar error, but it definitely needs to be tested.

[andrewbranch]

As I predicted, declaration emit does work. It did drop the type from declaration emit when the source file was JS, but that seems ok?

[weswigham]

It'd be nice if the js declaration emit preserved the type modifier, just in case someone uses the (admittedly internal) node builder APIs on typescript code (which is why it knows how to emit interfaces and such), but since it's an error it's non-critical.

[andrewbranch]

On second thought, having consistent declaration emit is also required to make errors consistent between referenced projects in the editor and on the CLI, so I went ahead and fixed it.