Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Annotate" exported object to fix named / namespace imports of our API in Node ESM #57133

Merged
merged 20 commits into from
Mar 4, 2024
Merged

"Annotate" exported object to fix named / namespace imports of our API in Node ESM #57133

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ecca161
Update checkModuleFormat.mjs to test imports
jakebailey Jan 22, 2024
43ea520
Support named / namespace imports of TypeScript API
jakebailey Jan 22, 2024
f452551
Simplify
jakebailey Jan 23, 2024
1f64ed0
fix lint
jakebailey Jan 23, 2024
8fe70bc
Fix esm smoke test, probably
jakebailey Jan 23, 2024
485ca88
fmt
jakebailey Jan 23, 2024
fedcbbc
Drop leftover metafile
jakebailey Jan 23, 2024
94fadba
Merge branch 'main' into annotate-exports
jakebailey Jan 24, 2024
e0d8ea5
Use require instead of dynamic import
jakebailey Jan 24, 2024
d8108fc
Rename for clarity
jakebailey Jan 24, 2024
9da7e26
Make output stable
jakebailey Jan 26, 2024
f414248
Use code from Evan, hack away __esModule
jakebailey Jan 26, 2024
ecf9aae
Leave a comment
jakebailey Jan 26, 2024
066537c
Merge branch 'main' into annotate-exports
jakebailey Jan 26, 2024
b1acdfa
Merge branch 'main' into annotate-exports
jakebailey Feb 27, 2024
9eb0f73
Merge branch 'main' into annotate-exports
jakebailey Feb 29, 2024
d47cef2
Set ts to module.exports to fix monaco
jakebailey Feb 29, 2024
c798c02
Document it
jakebailey Feb 29, 2024
66ee8fe
Fix again, exports is entirely reassigned, not augmented
jakebailey Feb 29, 2024
ec54653
Revert isNodeLikeSystem back to pre-5.0 state
jakebailey Mar 4, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set ts to module.exports to fix monaco
  • Loading branch information
@jakebailey
jakebailey committed Feb 29, 2024
commit d47cef200143140d843774dc659535fd8bce9355
2 changes: 1 addition & 1 deletion Herebyfile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ function createBundler(entrypoint, outfile, taskOptions = {}) {
};

if (taskOptions.exportIsTsObject) {
options.footer = { js: `})(typeof module !== "undefined" && module.exports ? module : { exports: ts });` };
options.footer = { js: `})(typeof module !== "undefined" && module.exports ? (ts = module.exports, module) : { exports: ts });` };

// esbuild converts calls to "require" to "__require"; this function
// calls the real require if it exists, or throws if it does not (rather than
Expand Down