Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use monocart for coverage reports, enable codecov #58850

Merged
merged 26 commits into from
Jul 17, 2024

Conversation

jakebailey
Copy link
Member

This is an experimental addition to c8, but works really well.

The v8 HTML page it outputs can load checker.ts without batting an eye, and has sub-expression fidelity and can see uncovered elses:

image

image

.c8rc.json Outdated Show resolved Hide resolved
@jakebailey
Copy link
Member Author

I'm going to revert the CI and codecov change until we can get faster runners to not double our CI time. The local thing is fine, though, so I'll leave that working. I'll also do a benchmark quick to see how the report collection changes.

@jakebailey
Copy link
Member Author

The new runner pool is fast enough to give us coverage without slowing down CI.

.c8rc.json Show resolved Hide resolved
@jakebailey jakebailey marked this pull request as ready for review June 19, 2024 22:11
@jakebailey
Copy link
Member Author

Marked this PR as ready for review. Now that the CI perf is mitigated, should we just go ahead and enable codecov?

@jakebailey jakebailey changed the title Use monocart for coverage reports Jun 25, 2024
@jakebailey
Copy link
Member Author

jakebailey commented Jun 26, 2024

A caveat is that c8 with monocart takes ~4x longer to run than c8 alone; reported cenfun/monocart-coverage-reports#47 and the profile is somewhat promising for improving this.

Now just 2x slower.

@jakebailey jakebailey merged commit ba46eca into microsoft:main Jul 17, 2024
30 checks passed
@jakebailey jakebailey deleted the coverage branch July 17, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
3 participants