Consider enclosing declaration when serializing inferred return types #59170

jakebailey · 2024-07-08T03:20:57Z

In playing around with the repros from #58937 and Effect-TS/effect#3171, I tried to go through the changes in #58546 to narrow things down to what might have caused the problem with inferred/unannotated return types.

One thread to pull on is that removing the context.mapper stuff seemed to fix the problem, but cause other undesirable changes.

Another area of note was serializeReturnTypeForSignatureWorker; he doc for tryReuseExistingTypeNodeHelper says:

/**
 * Do you mean to call this directly? You probably should use `tryReuseExistingTypeNode` instead,
 * which performs sanity checking on the type before doing this.
 */

serializeReturnTypeForSignatureWorker suspiciously calls tryReuseExistingTypeNodeHelper directly. I just swapped tryReuseExistingTypeNode in with parameters that seemed to make sense, and the repro cases appeared to snap back to what they used to be. For example, the declaration emit in Effect-TS/effect#3171 original post looked like this in 5.4:

export declare const traverse: {
    <A, R, O, E, B>(f: (a: A) => import("effect/Option").Option<B>): <TR, TO, TE>(self: import("effect/Record").ReadonlyRecord<string, A>) => import("effect/Option").Option<import("effect/Record").ReadonlyRecord<string, B>>;
    <TR_1, TO_1, TE_1, A_1, R_1, O_1, E_1, B_1>(self: import("effect/Record").ReadonlyRecord<string, A_1>, f: (a: A_1) => import("effect/Option").Option<B_1>): import("effect/Option").Option<import("effect/Record").ReadonlyRecord<string, B_1>>;
};

But in 5.5 is:

export declare const traverse: {
    <A, R, O, E, B>(f: (a: A) => import("effect/HKT").Kind<import("effect/Option").OptionTypeLambda, R, O, E, B>): <TR, TO, TE>(self: import("effect/HKT").Kind<import("effect/Record").ReadonlyRecordTypeLambda<string>, TR, TO, TE, A>) => import("effect/HKT").Kind<import("effect/Option").OptionTypeLambda, R, O, E, import("effect/HKT").Kind<import("effect/Record").ReadonlyRecordTypeLambda<string>, TR, TO, TE, B>>;
    <TR, TO, TE, A, R, O, E, B>(self: import("effect/Record").ReadonlyRecord<string, A>, f: (a: A) => import("effect/HKT").Kind<import("effect/Option").OptionTypeLambda, R, O, E, B>): import("effect/HKT").Kind<import("effect/Option").OptionTypeLambda, R, O, E, import("effect/HKT").Kind<import("effect/Record").ReadonlyRecordTypeLambda<string>, TR, TO, TE, B>>;
};

Note that we copies Kind out of the call signature of traverse. With this PR, we go to:

export declare const traverse: {
    <A, R, O, E, B>(f: (a: A) => import("effect/Option").Option<B>): <TR, TO, TE>(self: import("effect/Record").ReadonlyRecord<string, A>) => import("effect/Option").Option<import("effect/Record").ReadonlyRecord<string, B>>;
    <TR, TO, TE, A, R, O, E, B>(self: import("effect/Record").ReadonlyRecord<string, A>, f: (a: A) => import("effect/Option").Option<B>): import("effect/Option").Option<import("effect/Record").ReadonlyRecord<string, B>>;
};

Which is the best of both, in that Kind has gone away, and we still kept the better type parameter renaming behavior.

A number of other baselines "regressed" in that they seem to have less node reuse, but some appear to be more reasonable in some ways. Notably, no dts emit in our tests changed, which is good, but indicates that we need more testing here.

This is extremely unscientific. If this PR looks wrong, it should at least provide someone else with some info that could track the issue down better. ~~I'm not going to say that this is the fix to #58937 without a bit more consensus.~~

Fixes #58937

cc @weswigham @dragomirtitian

jakebailey · 2024-07-08T03:21:12Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-07-08T03:21:15Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-07-08T03:23:27Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162588/artifacts?artifactName=tgz&fileId=18C37DD5E439FF86EF8CC21F21AE94E5A03D9A893A11631A44B691130EF45D4602&fileName=/typescript-5.6.0-insiders.20240708.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.6.0-pr-59170-2".;

jakebailey · 2024-07-08T03:29:16Z

tests/baselines/reference/chainedCallsWithTypeParameterConstrainedToOtherTypeParameter.types

@@ -79,7 +79,7 @@ class C extends B {
 >A : typeof A
 >  : ^^^^^^^^
 >then : <S extends A>(cb: (x: A) => S) => Chain<S>


In examples like these, I think it's incredibly weird that the old behavior had us not reusing effectively anything but the return type annotation.

typescript-bot · 2024-07-08T03:41:45Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

jakebailey · 2024-07-08T03:45:23Z

tests/baselines/reference/declarationEmitQualifiedAliasTypeArgument.types

 >fun : () => import("bbb").INode<T>
->    : ^^^^^^       ^^^^^  ^^^^^ ^ 
+>    : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^


The old reuse here seems dubious to me; create is imported, so how are we reusing nodes from another file? Similarly to a lot of what changes in this PR.

tests/cases/compiler/issue58937.ts

typescript-bot · 2024-07-08T03:51:02Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59170/merge:

Everything looks good!

jakebailey · 2024-07-08T03:52:26Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-07-08T03:52:29Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-07-08T03:54:37Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162594/artifacts?artifactName=tgz&fileId=6B705B58AF6F6B24FC52A47A0AE0718118A689B306FE5B1C0CC81F06C358639402&fileName=/typescript-5.6.0-insiders.20240708.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.6.0-pr-59170-7".;

typescript-bot · 2024-07-08T04:04:04Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,361k (± 0.95%)}	_{192,848k (± 0.76%)}	_~	_192,149k	_195,844k	_{p=0.873 n=6}
_{Parse Time}	_{1.31s (± 0.31%)}	_{1.30s (± 1.49%)}	_~	_1.26s	_1.31s	_{p=0.248 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.44s (± 0.24%)}	_{9.44s (± 0.20%)}	_~	_9.42s	_9.47s	_{p=0.622 n=6}
_{Emit Time}	_{2.76s (± 0.60%)}	_{2.74s (± 0.23%)}	_~	_2.73s	_2.75s	_{p=0.070 n=6}
_{Total Time}	_{14.21s (± 0.27%)}	_{14.19s (± 0.22%)}	_~	_14.14s	_14.23s	_{p=0.687 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,369k (± 0.00%)}	_{1,218,396k (± 0.00%)}	_~	_1,218,328k	_1,218,446k	_{p=0.471 n=6}
_{Parse Time}	_{6.64s (± 0.48%)}	_{6.61s (± 0.35%)}	_~	_6.58s	_6.64s	_{p=0.120 n=6}
_{Bind Time}	_{1.86s (± 0.53%)}	_{1.86s (± 0.65%)}	_~	_1.85s	_1.88s	_{p=0.865 n=6}
_{Check Time}	_{30.59s (± 0.41%)}	_{30.67s (± 0.41%)}	_~	_30.51s	_30.78s	_{p=0.228 n=6}
_{Emit Time}	_{13.53s (± 0.90%)}	_{13.57s (± 0.24%)}	_~	_13.52s	_13.60s	_{p=0.872 n=6}
_{Total Time}	_{52.63s (± 0.29%)}	_{52.71s (± 0.23%)}	_~	_52.56s	_52.85s	_{p=0.470 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,140	_2,130,140	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,634	_927,634	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,106,185k (± 0.01%)}	_{2,106,181k (± 0.00%)}	_~	_2,106,029k	_2,106,307k	_{p=1.000 n=6}
_{Parse Time}	_{6.59s (± 0.36%)}	_{6.60s (± 0.20%)}	_~	_6.59s	_6.62s	_{p=0.460 n=6}
_{Bind Time}	_{2.33s (± 1.07%)}	_{2.31s (± 1.15%)}	_~	_2.27s	_2.35s	_{p=0.462 n=6}
_{Check Time}	_{70.40s (± 1.40%)}	_{70.84s (± 0.30%)}	_~	_70.66s	_71.23s	_{p=0.689 n=6}
_{Emit Time}	_{0.28s (±128.30%)}	_{0.13s (± 3.10%)}	_~	_0.13s	_0.14s	_{p=0.248 n=6}
_{Total Time}	_{79.60s (± 1.18%)}	_{79.89s (± 0.25%)}	_~	_79.73s	_80.27s	_{p=0.748 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,497	_1,225,508	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,459	_261,459	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,340,809k (± 0.03%)}	_{2,340,478k (± 0.02%)}	_~	_2,339,908k	_2,341,142k	_{p=0.471 n=6}
_{Parse Time}	_{5.01s (± 1.93%)}	_{5.08s (± 1.14%)}	_~	_5.03s	_5.18s	_{p=0.297 n=6}
_{Bind Time}	_{1.92s (± 0.61%)}	_{1.91s (± 0.27%)}	_~	_1.91s	_1.92s	_{p=0.191 n=6}
_{Check Time}	_{34.29s (± 0.65%)}	_{34.18s (± 0.44%)}	_~	_34.04s	_34.47s	_{p=0.378 n=6}
_{Emit Time}	_{2.61s (± 2.84%)}	_{2.67s (± 3.88%)}	_~	_2.59s	_2.87s	_{p=0.199 n=6}
_{Total Time}	_{43.86s (± 0.69%)}	_{43.86s (± 0.49%)}	_~	_43.66s	_44.25s	_{p=1.000 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,497	_1,225,508	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,459	_261,459	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,415,521k (± 0.02%)}	_{2,414,908k (± 0.05%)}	_~	_2,413,387k	_2,416,195k	_{p=0.471 n=6}
_{Parse Time}	_{6.24s (± 0.67%)}	_{6.27s (± 0.56%)}	_~	_6.24s	_6.33s	_{p=0.332 n=6}
_{Bind Time}	_{2.03s (± 1.05%)}	_{2.02s (± 0.41%)}	_~	_2.01s	_2.03s	_{p=0.806 n=6}
_{Check Time}	_{40.76s (± 0.12%)}	_{40.82s (± 0.58%)}	_~	_40.61s	_41.27s	_{p=0.936 n=6}
_{Emit Time}	_{3.10s (± 1.21%)}	_{3.17s (± 3.31%)}	_~	_3.06s	_3.33s	_{p=0.378 n=6}
_{Total Time}	_{52.14s (± 0.23%)}	_{52.30s (± 0.63%)}	_~	_51.98s	_52.83s	_{p=0.572 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,195	_258,195	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,737	_104,737	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,482k (± 0.01%)}	_{427,445k (± 0.03%)}	_~	_427,367k	_427,658k	_{p=0.173 n=6}
_{Parse Time}	_{4.07s (± 0.36%)}	_{4.08s (± 0.26%)}	_~	_4.07s	_4.10s	_{p=0.073 n=6}
_{Bind Time}	_{1.61s (± 1.32%)}	_{1.62s (± 1.68%)}	_~	_1.57s	_1.65s	_{p=0.681 n=6}
_{Check Time}	_{21.99s (± 0.31%)}	_{21.99s (± 0.30%)}	_~	_21.89s	_22.06s	_{p=0.686 n=6}
_{Emit Time}	_{1.55s (± 0.97%)}	_{1.57s (± 1.18%)}	_{+0.03s (+ 1.72%)}	_1.55s	_1.59s	_{p=0.037 n=6}
_{Total Time}	_{29.21s (± 0.26%)}	_{29.27s (± 0.22%)}	_~	_29.17s	_29.35s	_{p=0.377 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,486k (± 0.03%)}	_{369,609k (± 0.05%)}	_~	_369,432k	_369,818k	_{p=0.298 n=6}
_{Parse Time}	_{3.45s (± 1.08%)}	_{3.45s (± 0.80%)}	_~	_3.41s	_3.48s	_{p=0.808 n=6}
_{Bind Time}	_{1.93s (± 1.20%)}	_{1.93s (± 0.39%)}	_~	_1.92s	_1.94s	_{p=0.870 n=6}
_{Check Time}	_{19.14s (± 0.41%)}	_{19.13s (± 0.53%)}	_~	_18.98s	_19.23s	_{p=0.873 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.52s (± 0.49%)}	_{24.51s (± 0.48%)}	_~	_24.36s	_24.64s	_{p=0.688 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,882,609	_2,882,609	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,856	_975,856	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,045,852k (± 0.00%)}	_{3,045,892k (± 0.00%)}	_~	_3,045,818k	_3,046,048k	_{p=0.471 n=6}
_{Parse Time}	_{16.85s (± 0.21%)}	_{16.88s (± 0.27%)}	_~	_16.84s	_16.96s	_{p=0.413 n=6}
_{Bind Time}	_{5.04s (± 0.39%)}	_{5.09s (± 1.79%)}	_~	_5.01s	_5.27s	_{p=0.168 n=6}
_{Check Time}	_{89.49s (± 2.05%)}	_{89.57s (± 1.10%)}	_~	_88.84s	_91.51s	_{p=0.298 n=6}
_{Emit Time}	_{28.25s (± 6.43%)}	_{28.61s (± 3.51%)}	_~	_26.57s	_29.15s	_{p=0.575 n=6}
_{Total Time}	_{139.64s (± 0.41%)}	_{140.15s (± 0.26%)}	_~	_139.66s	_140.57s	_{p=0.173 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,626k (± 0.03%)}	_{411,592k (± 0.02%)}	_~	_411,499k	_411,756k	_{p=0.575 n=6}
_{Parse Time}	_{4.71s (± 0.25%)}	_{4.72s (± 0.80%)}	_~	_4.67s	_4.76s	_{p=0.935 n=6}
_{Bind Time}	_{2.09s (± 0.58%)}	_{2.09s (± 1.08%)}	_~	_2.05s	_2.11s	_{p=0.806 n=6}
_{Check Time}	_{20.78s (± 0.24%)}	_{20.79s (± 0.57%)}	_~	_20.64s	_20.96s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.58s (± 0.15%)}	_{27.60s (± 0.49%)}	_~	_27.41s	_27.77s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,587k (± 0.08%)}	_{462,604k (± 0.08%)}	_~	_462,315k	_463,145k	_{p=0.575 n=6}
_{Parse Time}	_{3.17s (± 0.73%)}	_{3.18s (± 0.62%)}	_~	_3.15s	_3.20s	_{p=0.746 n=6}
_{Bind Time}	_1.17s	_1.17s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{17.93s (± 0.40%)}	_{17.93s (± 0.34%)}	_~	_17.86s	_18.01s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.27s (± 0.24%)}	_{22.28s (± 0.26%)}	_~	_22.20s	_22.37s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-08T04:13:31Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-08T04:16:34Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59170/merge:

Everything looks good!

typescript-bot · 2024-07-08T04:34:46Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,584k (± 0.96%)}	_{192,214k (± 0.07%)}	_{-2,370k (- 1.22%)}	_192,081k	_192,479k	_{p=0.045 n=6}
_{Parse Time}	_{1.30s (± 1.19%)}	_{1.30s (± 0.75%)}	_~	_1.29s	_1.31s	_{p=0.933 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.45s (± 0.22%)}	_{9.46s (± 0.55%)}	_~	_9.38s	_9.53s	_{p=0.514 n=6}
_{Emit Time}	_{2.75s (± 0.91%)}	_{2.74s (± 0.88%)}	_~	_2.71s	_2.78s	_{p=1.000 n=6}
_{Total Time}	_{14.21s (± 0.14%)}	_{14.22s (± 0.35%)}	_~	_14.18s	_14.31s	_{p=0.454 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,391k (± 0.00%)}	_{1,218,360k (± 0.00%)}	_~	_1,218,284k	_1,218,427k	_{p=0.378 n=6}
_{Parse Time}	_{6.66s (± 0.86%)}	_{6.67s (± 0.74%)}	_~	_6.62s	_6.75s	_{p=0.688 n=6}
_{Bind Time}	_{1.86s (± 0.68%)}	_{1.86s (± 0.63%)}	_~	_1.84s	_1.87s	_{p=1.000 n=6}
_{Check Time}	_{30.68s (± 0.36%)}	_{30.52s (± 0.23%)}	_{-0.17s (- 0.55%)}	_30.44s	_30.62s	_{p=0.030 n=6}
_{Emit Time}	_{13.54s (± 0.72%)}	_{13.58s (± 0.47%)}	_~	_13.49s	_13.68s	_{p=0.571 n=6}
_{Total Time}	_{52.74s (± 0.40%)}	_{52.63s (± 0.25%)}	_~	_52.47s	_52.78s	_{p=0.336 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,140	_2,130,140	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,634	_927,634	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,106,213k (± 0.01%)}	_{2,106,137k (± 0.00%)}	_~	_2,106,095k	_2,106,197k	_{p=0.230 n=6}
_{Parse Time}	_{6.59s (± 0.37%)}	_{6.62s (± 0.17%)}	_~	_6.61s	_6.64s	_{p=0.052 n=6}
_{Bind Time}	_{2.31s (± 0.75%)}	_{2.31s (± 0.51%)}	_~	_2.30s	_2.33s	_{p=0.803 n=6}
_{Check Time}	_{70.61s (± 0.24%)}	_{70.51s (± 0.29%)}	_~	_70.18s	_70.77s	_{p=0.471 n=6}
_{Emit Time}	_{0.13s (± 3.10%)}	_{0.14s (± 2.95%)}	_{🔻+0.01s (+ 5.06%)}	_0.13s	_0.14s	_{p=0.034 n=6}
_{Total Time}	_{79.65s (± 0.23%)}	_{79.58s (± 0.26%)}	_~	_79.24s	_79.83s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,497	_1,225,508	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,459	_261,459	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,342,148k (± 0.04%)}	_{2,341,379k (± 0.03%)}	_~	_2,340,112k	_2,342,216k	_{p=0.128 n=6}
_{Parse Time}	_{6.04s (± 0.62%)}	_{6.04s (± 0.69%)}	_~	_6.00s	_6.11s	_{p=0.688 n=6}
_{Bind Time}	_{2.26s (± 0.63%)}	_{2.26s (± 0.60%)}	_~	_2.24s	_2.27s	_{p=0.807 n=6}
_{Check Time}	_{40.21s (± 0.35%)}	_{40.18s (± 0.30%)}	_~	_40.05s	_40.36s	_{p=0.575 n=6}
_{Emit Time}	_{3.02s (± 4.31%)}	_{3.16s (± 5.81%)}	_~	_2.88s	_3.40s	_{p=0.230 n=6}
_{Total Time}	_{51.55s (± 0.46%)}	_{51.65s (± 0.58%)}	_~	_51.18s	_52.01s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,497	_1,225,508	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,459	_261,459	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,414,873k (± 0.02%)}	_{2,414,090k (± 0.03%)}	_~	_2,412,971k	_2,414,813k	_{p=0.066 n=6}
_{Parse Time}	_{5.20s (± 0.49%)}	_{5.23s (± 1.12%)}	_~	_5.15s	_5.30s	_{p=0.470 n=6}
_{Bind Time}	_{1.70s (± 0.94%)}	_{1.69s (± 1.02%)}	_~	_1.67s	_1.72s	_{p=0.514 n=6}
_{Check Time}	_{34.72s (± 0.52%)}	_{34.73s (± 0.71%)}	_~	_34.55s	_35.21s	_{p=0.810 n=6}
_{Emit Time}	_{2.69s (± 2.66%)}	_{2.70s (± 1.85%)}	_~	_2.62s	_2.77s	_{p=0.810 n=6}
_{Total Time}	_{44.30s (± 0.55%)}	_{44.34s (± 0.74%)}	_~	_44.10s	_44.97s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,195	_258,195	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,737	_104,737	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,454k (± 0.01%)}	_{427,427k (± 0.01%)}	_~	_427,388k	_427,458k	_{p=0.229 n=6}
_{Parse Time}	_{4.08s (± 0.10%)}	_{4.09s (± 0.72%)}	_~	_4.06s	_4.13s	_{p=0.451 n=6}
_{Bind Time}	_{1.63s (± 0.78%)}	_{1.62s (± 1.21%)}	_~	_1.59s	_1.65s	_{p=0.567 n=6}
_{Check Time}	_{21.97s (± 0.39%)}	_{22.05s (± 0.33%)}	_~	_21.92s	_22.13s	_{p=0.229 n=6}
_{Emit Time}	_{1.55s (± 1.94%)}	_{1.59s (± 0.73%)}	_{+0.04s (+ 2.47%)}	_1.57s	_1.60s	_{p=0.022 n=6}
_{Total Time}	_{29.23s (± 0.30%)}	_{29.35s (± 0.31%)}	_~	_29.22s	_29.45s	_{p=0.066 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,505k (± 0.02%)}	_{369,490k (± 0.04%)}	_~	_369,359k	_369,777k	_{p=0.378 n=6}
_{Parse Time}	_{2.78s (± 0.60%)}	_{2.78s (± 1.06%)}	_~	_2.73s	_2.80s	_{p=0.743 n=6}
_{Bind Time}	_{1.60s (± 1.81%)}	_{1.59s (± 1.17%)}	_~	_1.57s	_1.61s	_{p=0.459 n=6}
_{Check Time}	_{15.52s (± 0.39%)}	_{15.51s (± 0.28%)}	_~	_15.46s	_15.58s	_{p=0.628 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.89s (± 0.35%)}	_{19.87s (± 0.28%)}	_~	_19.83s	_19.98s	_{p=0.572 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,882,609	_2,882,609	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,856	_975,856	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,045,880k (± 0.00%)}	_{3,045,928k (± 0.00%)}	_~	_3,045,818k	_3,046,009k	_{p=0.199 n=6}
_{Parse Time}	_{16.89s (± 0.32%)}	_{16.92s (± 0.46%)}	_~	_16.84s	_17.02s	_{p=0.575 n=6}
_{Bind Time}	_{5.13s (± 2.08%)}	_{5.13s (± 1.90%)}	_~	_5.08s	_5.33s	_{p=0.807 n=6}
_{Check Time}	_{90.81s (± 2.61%)}	_{90.95s (± 2.40%)}	_~	_89.30s	_94.65s	_{p=0.575 n=6}
_{Emit Time}	_{27.70s (± 8.64%)}	_{27.80s (± 7.23%)}	_~	_24.67s	_29.25s	_{p=0.936 n=6}
_{Total Time}	_{140.53s (± 0.10%)}	_{140.80s (± 0.23%)}	_~	_140.50s	_141.29s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,590k (± 0.01%)}	_{411,584k (± 0.01%)}	_~	_411,553k	_411,631k	_{p=0.810 n=6}
_{Parse Time}	_{3.81s (± 0.61%)}	_{3.82s (± 0.81%)}	_~	_3.78s	_3.87s	_{p=1.000 n=6}
_{Bind Time}	_{1.68s (± 0.32%)}	_{1.68s (± 0.72%)}	_~	_1.66s	_1.69s	_{p=0.855 n=6}
_{Check Time}	_{16.71s (± 0.38%)}	_{16.78s (± 0.46%)}	_~	_16.66s	_16.86s	_{p=0.170 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.21s (± 0.32%)}	_{22.28s (± 0.29%)}	_~	_22.16s	_22.34s	_{p=0.149 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,917k (± 0.05%)}	_{462,609k (± 0.06%)}	_~	_462,410k	_463,035k	_{p=0.066 n=6}
_{Parse Time}	_{3.95s (± 0.59%)}	_{3.95s (± 0.34%)}	_~	_3.93s	_3.96s	_{p=0.676 n=6}
_{Bind Time}	_{1.46s (± 1.42%)}	_{1.46s (± 0.67%)}	_~	_1.45s	_1.47s	_{p=0.565 n=6}
_{Check Time}	_{22.25s (± 0.43%)}	_{22.19s (± 0.42%)}	_~	_22.03s	_22.31s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{27.65s (± 0.39%)}	_{27.61s (± 0.35%)}	_~	_27.44s	_27.73s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-08T05:03:02Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59170/merge:

Everything looks good!

typescript-bot · 2024-07-08T05:32:54Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59170/merge:

Everything looks good!

dragomirtitian · 2024-07-08T17:05:54Z

src/compiler/checker.ts

-                // To ensure we don't serialize the wrong type we check that that return type of the signature corresponds to the declaration return type signature
-                if (annotation && getTypeFromTypeNode(context, annotation) === type) {
-                    const result = tryReuseExistingTypeNodeHelper(context, annotation);
+                const annotation = getNonlocalEffectiveReturnTypeAnnotationNode(signature.declaration);


Are we sure removing this check getTypeFromTypeNode(context, annotation) === type is a good idea? I think there are cases where the type of the annotation might differ from the type of the signature.

That's what tryReuseExistingTypeNode does internally and is how it differs from tryReuseExistingTypeNodeHelper

Right; removing this didn't change anything except reducing some type instantiations. Sorry, I rebased that particular thing away because I felt pretty confident that I could remove the equality here.

jakebailey · 2024-07-08T17:26:03Z

Interestingly, this is not the fix for the type display issue from DefinitelyTyped/DefinitelyTyped#69838.

gcanti · 2024-07-09T07:31:37Z

I can confirm that installing the npm package referenced here #59170 (comment) fixes the type display issue reported in Effect-TS/effect#3171

jakebailey · 2024-07-09T15:39:29Z

Thanks for confirming; I'm going to make one last attempt to make a repro that exhibits the "cannot be named" error before merging/backporting.

jakebailey · 2024-07-09T20:45:40Z

Okay, I give up trying to produce a test case for the cannot be named error.

jakebailey · 2024-07-09T20:49:52Z

@typescript-bot cherry-pick this to release-5.5

typescript-bot · 2024-07-09T20:49:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.5`	✅ Started	❌ Results

typescript-bot · 2024-07-09T21:03:28Z

Hey, @jakebailey! I was unable to cherry-pick this PR.

Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/9863981289

jakebailey · 2024-07-09T21:04:26Z

Okay, guess I'll do it manually

…microsoft#59170)

typescript-bot assigned jakebailey Jul 8, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 8, 2024

jakebailey commented Jul 8, 2024

View reviewed changes

This was referenced Jul 8, 2024

Regression in Type Inference for functions derived from typeclasses in TypeScript 5.5.x Effect-TS/effect#3171

Open

Some long function return expressions no longer evaluated in 5.5 #58937

Closed

jakebailey commented Jul 8, 2024

View reviewed changes

tests/cases/compiler/issue58937.ts Outdated Show resolved Hide resolved

jakebailey changed the title ~~Ensure we consider enclosing declaration when attempting to reuse nodes in return types~~ Jul 8, 2024

jakebailey force-pushed the fix-58937 branch from ecd66f9 to 27b20b0 Compare July 8, 2024 15:55

weswigham approved these changes Jul 8, 2024

View reviewed changes

dragomirtitian reviewed Jul 8, 2024

View reviewed changes

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 8, 2024

jakebailey force-pushed the fix-58937 branch from 27b20b0 to dc2329c Compare July 9, 2024 20:45

jakebailey added 3 commits July 9, 2024 14:09

test

1215d8e

Fix and do one test

189f1e2

Accept the rest

337c886

jakebailey force-pushed the fix-58937 branch from dc2329c to 337c886 Compare July 9, 2024 21:12

jakebailey merged commit 533acb5 into microsoft:main Jul 9, 2024
29 checks passed

jakebailey deleted the fix-58937 branch July 9, 2024 21:35

jakebailey added a commit to jakebailey/TypeScript that referenced this pull request Jul 9, 2024

Consider enclosing declaration when serializing inferred return types (…

aae1585

…microsoft#59170)

jakebailey mentioned this pull request Jul 10, 2024

Fix baselines from PR 59203 #59216

Merged

DanielRosenwasser mentioned this pull request Jul 16, 2024

Cherry-pick PR #59170 to release-5.5 #59212

Merged

DanielRosenwasser added this to the TypeScript 5.5.4 milestone Jul 16, 2024

DanielRosenwasser pushed a commit that referenced this pull request Jul 16, 2024

Cherry-pick PR #59170 to release-5.5 (#59212)

c4108b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consider enclosing declaration when serializing inferred return types #59170

Consider enclosing declaration when serializing inferred return types #59170

jakebailey commented Jul 8, 2024 •

edited

Loading

jakebailey commented Jul 8, 2024

typescript-bot commented Jul 8, 2024 •

edited

Loading

typescript-bot commented Jul 8, 2024 •

edited

Loading

jakebailey Jul 8, 2024

typescript-bot commented Jul 8, 2024

jakebailey Jul 8, 2024

typescript-bot commented Jul 8, 2024

jakebailey commented Jul 8, 2024

typescript-bot commented Jul 8, 2024 •

edited

Loading

typescript-bot commented Jul 8, 2024 •

edited

Loading

typescript-bot commented Jul 8, 2024

tsc

typescript-bot commented Jul 8, 2024

typescript-bot commented Jul 8, 2024

typescript-bot commented Jul 8, 2024

tsc

typescript-bot commented Jul 8, 2024

typescript-bot commented Jul 8, 2024

dragomirtitian Jul 8, 2024

weswigham Jul 8, 2024

jakebailey Jul 8, 2024

jakebailey commented Jul 8, 2024

gcanti commented Jul 9, 2024

jakebailey commented Jul 9, 2024

jakebailey commented Jul 9, 2024

jakebailey commented Jul 9, 2024

typescript-bot commented Jul 9, 2024 •

edited

Loading

typescript-bot commented Jul 9, 2024

jakebailey commented Jul 9, 2024

Consider enclosing declaration when serializing inferred return types #59170

Consider enclosing declaration when serializing inferred return types #59170

Conversation

jakebailey commented Jul 8, 2024 • edited Loading

jakebailey commented Jul 8, 2024

typescript-bot commented Jul 8, 2024 • edited Loading

typescript-bot commented Jul 8, 2024 • edited Loading

jakebailey Jul 8, 2024

Choose a reason for hiding this comment

typescript-bot commented Jul 8, 2024

jakebailey Jul 8, 2024

Choose a reason for hiding this comment

typescript-bot commented Jul 8, 2024

jakebailey commented Jul 8, 2024

typescript-bot commented Jul 8, 2024 • edited Loading

typescript-bot commented Jul 8, 2024 • edited Loading

typescript-bot commented Jul 8, 2024

tsc

typescript-bot commented Jul 8, 2024

typescript-bot commented Jul 8, 2024

typescript-bot commented Jul 8, 2024

tsc

typescript-bot commented Jul 8, 2024

typescript-bot commented Jul 8, 2024

dragomirtitian Jul 8, 2024

Choose a reason for hiding this comment

weswigham Jul 8, 2024

Choose a reason for hiding this comment

jakebailey Jul 8, 2024

Choose a reason for hiding this comment

jakebailey commented Jul 8, 2024

gcanti commented Jul 9, 2024

jakebailey commented Jul 9, 2024

jakebailey commented Jul 9, 2024

jakebailey commented Jul 9, 2024

typescript-bot commented Jul 9, 2024 • edited Loading

typescript-bot commented Jul 9, 2024

jakebailey commented Jul 9, 2024

jakebailey commented Jul 8, 2024 •

edited

Loading

typescript-bot commented Jul 8, 2024 •

edited

Loading

typescript-bot commented Jul 8, 2024 •

edited

Loading

typescript-bot commented Jul 8, 2024 •

edited

Loading

typescript-bot commented Jul 8, 2024 •

edited

Loading

typescript-bot commented Jul 9, 2024 •

edited

Loading