Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyleCop upgrade and many warning was resolved or disabled #261

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

soroshsabz
Copy link

ITNOA

  • I update StyleCop and disable some terrible warnings
  • I add some check main thread for better compatibility in Async era
@soroshsabz
Copy link
Author

@adrianvmsft Please review my PR.

thanks :)

@soroshsabz
Copy link
Author

Some great notes about VS Threading can found in VS Threading Cookbook

@soroshsabz
Copy link
Author

@adrianvmsft after one day, CI is not reported yet, Did you can run CI manually?

thanks

@soroshsabz
Copy link
Author

@adrianvmsft Did you have plan to review it? I have another PR for #257 and I want to create it after this

thanks

@soroshsabz
Copy link
Author

@adrianvmsft Did you can review this PR?

thanks

@soroshsabz
Copy link
Author

@adrianvmsft Why CI does not work?

@soroshsabz
Copy link
Author

@adrianvmsft Did you can review this PR?

thanks

1 similar comment
@soroshsabz
Copy link
Author

@adrianvmsft Did you can review this PR?

thanks

@soroshsabz
Copy link
Author

Any update?

@soroshsabz
Copy link
Author

soroshsabz commented Feb 17, 2023

@ttstanley @adrianvmsft please review this PR

I update this PR, and resolve all conflicts.

@soroshsabz
Copy link
Author

soroshsabz commented Feb 17, 2023

@ttstanley Did you can review this PR, and if this is okey, merge it?

thanks

@soroshsabz
Copy link
Author

@ttstanley @adrianvmsft any update?

@soroshsabz
Copy link
Author

@ttstanley @adrianvmsft any update?

@soroshsabz
Copy link
Author

@ttstanley @adrianvmsft Any update?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant