Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glad] update to glad2 #31061

Closed
jasperdrescher opened this issue Apr 22, 2023 · 9 comments · May be fixed by #31103
Closed

[glad] update to glad2 #31061

jasperdrescher opened this issue Apr 22, 2023 · 9 comments · May be fixed by #31103
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision Stale

Comments

@jasperdrescher
Copy link

Library name

glad

New version number

glad2

Other information that may be useful (release notes, etc...)

Hi, this is not exactly a version update, but it doesn't look like the glad package in vcpkg uses the default branch glad2 of the glad repository. The functionality and include seem different between the master (glad) and glad2 branch. Can this somehow be updated please?

@jasperdrescher jasperdrescher added the category:port-update The issue is with a library, which is requesting update new revision label Apr 22, 2023
@LilyWangLL LilyWangLL self-assigned this Apr 23, 2023
@jasperdrescher
Copy link
Author

@LilyWangLL do you think it would be better to introduce a new package called glad2, similar to glfw3? Or is it possible to switch the branch from master to glad2 for this package, although that could break existing project?

@LilyWangLL
Copy link
Contributor

I noticed that the upstream has been releasing version 2.0 since last year and is no longer updating version 0.1. Therefore, my point is to upgrade glad to version 2.0, and I am trying to update glad locally.

@LilyWangLL
Copy link
Contributor

@jasperdrescher
I found that glad2 no longer provides complete CMake build files, the related links: Dav1dde/glad#244. Glad2 only has one file CMakeLists.txt under the subdirectory cmake, which just provides functions. If we want to update glad to glad2, we need to write new CMakeLists.txt. I'm not very familiar with the use of glad, would you be interested in doing this?

@jasperdrescher
Copy link
Author

jasperdrescher commented Apr 24, 2023

@LilyWangLL
This repo uses glad2 with CMake and it uses the glad_add_library function for CMakeLists: https://github.com/jasperdrescher/HelloOpenGL/blob/main/CMake/glad.cmake. If needed I can try to update the package.

@jasperdrescher
Copy link
Author

@LilyWangLL I'll try to update the port to glad2 on a fork and see how far I get today 😄

@jasperdrescher
Copy link
Author

@LilyWangLL trying to add a CMakeLists.txt to the glad port and testing that locally is more complicated/vague than I expected. It would be appreciated if you could help out, as I'm not as familiar with Vcpkg and the required steps when modifying a port.

@LilyWangLL
Copy link
Contributor

You could submit a PR to do this, our team and other contributors could give the suggestions for this update.

@github-actions
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Apr 21, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision Stale
2 participants