Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glad] Update to v2.0.4 #31103

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

[glad] Update to v2.0.4 #31103

wants to merge 11 commits into from
+17 −42

Conversation

jasperdrescher
Copy link

@jasperdrescher jasperdrescher commented Apr 25, 2023 •
edited
Loading

Fixes #31061

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
@Cheney-W Cheney-W self-assigned this Apr 25, 2023
@jasperdrescher
Copy link
Author

@microsoft-github-policy-service agree
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Apr 25, 2023
@jasperdrescher
Copy link
Author

This PR is not ready, but I could use some feedback or help figuring out how to add a CMakeLists to this port, as it now is required with glad2. I also am not sure how to update the hash accurately to get the changes from remote.
@jasperdrescher jasperdrescher changed the title [glad] Update to glad2 Apr 25, 2023
Cheney-W
Cheney-W reviewed Apr 28, 2023
View reviewed changes
ports/glad/portfile.cmake Outdated Show resolved Hide resolved
@Cheney-W
Copy link
Contributor

Please add file(COPY "${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt" DESTINATION "${SOURCE_PATH}") after vcpkg_from_github() function.
Cheney-W
Cheney-W reviewed Apr 28, 2023
View reviewed changes
ports/glad/CMakeLists.txt Outdated Show resolved Hide resolved
jasperdrescher
jasperdrescher commented Apr 28, 2023
View reviewed changes
ports/glad/CMakeLists.txt
project(glad C CXX)

add_subdirectory(cmake)
glad_add_library(glad_gl_core_46 STATIC REPRODUCIBLE API gl:core=4.6)
Copy link
Author

@jasperdrescher jasperdrescher Apr 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here is that I'm not sure what to add the library to, as it won't create a lib this way.
@Cheney-W
Copy link
Contributor

Cheney-W commented May 4, 2023 

ninja: error: unknown target 'install'

You should install the target, please refer to the following contents:

install(TARGETS CTL
    	LIBRARY DESTINATION lib
    	ARCHIVE DESTINATION lib)
@Cheney-W
Copy link
Contributor

Cheney-W commented May 5, 2023

When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
2 participants
@jasperdrescher @Cheney-W