Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We��ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openh264] (fixed upstream) openh264.pc references -lstdc++ on Windows, breaking gstreamer #32586

Open
comex opened this issue Jul 17, 2023 · 3 comments · May be fixed by #32590
Open

[openh264] (fixed upstream) openh264.pc references -lstdc++ on Windows, breaking gstreamer #32586

comex opened this issue Jul 17, 2023 · 3 comments · May be fixed by #32590
Assignees
@FrankXie05
Labels
category:port-update The issue is with a library, which is requesting update new revision Stale

Comments

@comex
Copy link

comex commented Jul 17, 2023

Describe the bug
When building openh264 natively on Windows, the generated pkg-config file has a reference to -lstdc++, which isn't used on native Windows targets.

This appears to be fixed upstream already: if I add HEAD_REF master to portfile.cmake and build with --head, the pkg-config file is correct. The fix was probably this PR merged in 2022.

Environment

  • OS: Windows
  • Compiler: Visual Studio 2022

To Reproduce
Steps to reproduce the behavior:

  1. ./vcpkg install openh264:x64-windows-static
  2. Look at packages/openh264_x64-windows-static/lib/pkgconfig/openh264.pc and note that it includes:
Libs.private: -lstdc++
  1. Run ./vcpkg install gstreamer[openh264]:x64-windows-static and it will fail with:
LINK : fatal error LNK1181: cannot open input file 'stdc++.lib'

If you build for x64-windows instead of x64-windows-static, the pkg-config file is still incorrect, but it doesn't break gstreamer since Libs.private isn't used for dynamic linking.
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 17, 2023
@FrankXie05
Copy link
Contributor

PR cisco/openh264#3247 for c++ porting.
@FrankXie05 FrankXie05 linked a pull request Jul 17, 2023 that will close this issue
Draft
7 tasks
@github-actions GitHub Actions
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.
@github-actions github-actions bot added the Stale label Jan 14, 2024
@FrankXie05 FrankXie05 removed the Stale label Jan 15, 2024
@github-actions GitHub Actions
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.
@github-actions github-actions bot added the Stale label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision Stale
2 participants
@comex @FrankXie05