Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openh264] Update version to 2.3.1 #32590

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

[openh264] Update version to 2.3.1 #32590

wants to merge 8 commits into from

Conversation

FrankXie05
Copy link
Contributor

Fix #32586

Note: update openh264 version to 2.3.1.
No feature needs to test.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
@FrankXie05 FrankXie05 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jul 17, 2023
@FrankXie05
Copy link
Contributor Author

/azp run
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@FrankXie05
Copy link
Contributor Author 

BUILD_ARCH=x86_64
OPTION_VARIABLE=OPTIONS_x86_64
=== CONFIGURING ===
ERROR: openh264 not found using pkg-config

Looks like ffmpeg needs to be checked. 🤔
dg0yt
dg0yt reviewed Jul 25, 2023
View reviewed changes
ports/openh264/portfile.cmake
get_filename_component(PKGCONFIG_PATH "${PKGCONFIG}" DIRECTORY)
vcpkg_add_to_path("${PKGCONFIG_PATH}")

set(ENV{PKGCONFIG_PATH} "${CURRENT_INSTALLED_DIR}/lib/pkgconfig")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vcpkg_configure_meson correctly sets PKG_CONFIG_PATH (!) for each build type.
ports/openh264/portfile.cmake
Comment on lines +21 to +23
set(ENV{PKG_CONFIG} "${PKGCONFIG}")
get_filename_component(PKGCONFIG_PATH "${PKGCONFIG}" DIRECTORY)
vcpkg_add_to_path("${PKGCONFIG_PATH}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either setting ENV{PKG_CONFIG} or adding to the path should be enough.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is also handled implicitly by vcpkg_configure_meson via z_vcpkg_setup_pkgconfig_path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team.
3 participants
@FrankXie05 @dg0yt @Cheney-W