Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add prusaslicer #29938

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from
Draft

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Mar 1, 2023

too late to fill out

@Cheney-W Cheney-W added category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-update The issue is with a library, which is requesting update new revision labels Mar 1, 2023
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Mar 1, 2023

@Cheney-W Hmm somebody should probably investigate the libigl[cgal] regressions here. probably fixed by #27963

@Neumann-A
Copy link
Contributor Author

Hmm I probably can close this since this doesn't seem to install a library. I thought it would be library + tool and i could deactivate the tool. However this demonstrates how important applications are in actually testing upstream libs for problems.

@dg0yt
Copy link
Contributor

dg0yt commented Mar 1, 2023

However this demonstrates how important applications are in actually testing upstream libs for problems.

Seconded. No apps and no tests = lottery. (That's why I added the CI build of example apps for skia and wxwidgets.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-update The issue is with a library, which is requesting update new revision
4 participants