Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cln] add libcln #32996

Closed
wants to merge 17 commits into from
Closed

[cln] add libcln #32996

wants to merge 17 commits into from

Conversation

endingly
Copy link
Contributor

@endingly endingly commented Aug 6, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 7, 2023
@LilyWangLL
Copy link
Contributor

Thanks for your PR, please fix the build error on CI pipeline. If this port doesn't support these triplets, please add supports in vcpkg.json.

libcln:x64-uwp
libcln:arm-uwp
libcln:arm-neon-android
@LilyWangLL
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@LilyWangLL LilyWangLL marked this pull request as draft August 7, 2023 02:50
@endingly
Copy link
Contributor Author

endingly commented Aug 7, 2023

Thanks for your PR, please fix the build error on CI pipeline. If this port doesn't support these triplets, please add supports in vcpkg.json.

libcln:x64-uwp
libcln:arm-uwp
libcln:arm-neon-android

What is platform expression of arm-neon-android ?

@endingly endingly marked this pull request as ready for review August 7, 2023 08:26
@endingly endingly marked this pull request as draft August 7, 2023 09:05
@endingly endingly changed the title [libcln] add libcln Aug 7, 2023
@endingly endingly marked this pull request as ready for review August 7, 2023 10:38
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the usage should be trimmed to

cln provides CMake targets:

    find_package(cln CONFIG REQUIRED)
    target_link_libraries(main PRIVATE cln::cln)
@@ -0,0 +1,35 @@
vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a general limitation, or just the lack of Windows DLL export definitions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Windows, if compiling dynamic libraries, two errors will occur:

  1. redefinition of symbol
  2. unable to parse some symbols in the library
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I gave up. I moved Windows out of the support list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(VCPKG_TARGET_IS_WINDOWS)
    vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
endif()
ports/cln/portfile.cmake Outdated Show resolved Hide resolved
ports/cln/usage Outdated Show resolved Hide resolved
@endingly endingly marked this pull request as draft August 8, 2023 08:17
@LilyWangLL
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.

@LilyWangLL LilyWangLL closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
3 participants