Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eigen3] update to 3.4.1 from 3.4.0 #34542

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[eigen3] update to 3.4.1 from 3.4.0 #34542

wants to merge 3 commits into from
+11 −34

Conversation

alxvth
Copy link

@alxvth alxvth commented Oct 17, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The fix-vectorized-reductions-half.patch is no longer necessary since version 3.4.1 incorporates that fix itself.
@alxvth
Copy link
Author

alxvth commented Oct 17, 2023

@microsoft-github-policy-service agree
dg0yt
dg0yt reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant as a draft?

Once there is a 3.4.1 release:
ports/eigen3/portfile.cmake
REF 3.4.0
SHA512 ba75ecb760e32acf4ceaf27115468e65d4f77c44f8d519b5a13e7940af2c03a304ad433368cb6d55431f307c5c39e2666ab41d34442db3cf441638e51f5c3b6a
HEAD_REF master
REF 7176ae16238ded7fb5ed30a7f5215825b3abd134
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REF 7176ae16238ded7fb5ed30a7f5215825b3abd134
REF "${VERSION}"
ports/eigen3/portfile.cmake
HEAD_REF master
REF 7176ae16238ded7fb5ed30a7f5215825b3abd134
SHA512 b258dcafe52153c3698c43c13abfd73d7f8d8c81970247f867aadadd4c602800015abe0403904cbbb3a4cb195bad9527734033970c197f3bb057c8345094a7bb
HEAD_REF 3.4.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HEAD_REF 3.4.1
HEAD_REF master
@alxvth
Copy link
Author

alxvth commented Oct 17, 2023

Is this meant as a draft?

Once there is a 3.4.1 release:

Ah yes, that's a better idea!
@alxvth alxvth marked this pull request as draft October 17, 2023 14:35
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
3 participants
@alxvth @dg0yt @FrankXie05