Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ports/libsigsegv] New port #35144

Closed
wants to merge 6 commits into from
Closed

[ports/libsigsegv] New port #35144

wants to merge 6 commits into from

Conversation

SamuelMarks
Copy link
Contributor

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Running it through your CI for Windows support, then will switch to draft?

Windows install instructions:
https://git.savannah.gnu.org/gitweb/?p=libsigsegv.git;a=blob;f=INSTALL.windows;h=b41d0123592a89f33595f395625752fe103333dc;hb=HEAD
@SamuelMarks SamuelMarks marked this pull request as draft November 16, 2023 04:16
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 16, 2023
@MonicaLiu0311
Copy link
Contributor

Please get failure logs here.

Installing 1/1 libsigsegv:x64-windows...
Building libsigsegv:x64-windows...
-- Downloading https://ftp.gnu.org/gnu/libsigsegv/libsigsegv-2.14.tar.gz;https://www.mirrorservice.org/sites/ftp.gnu.org/gnu/libsigsegv/libsigsegv-2.14.tar.gz -> libsigsegv-2.14.tar.gz...
-- Extracting source D:/downloads/libsigsegv-2.14.tar.gz
-- Using source at D:/buildtrees/libsigsegv/src/bsigsegv-2-fd354ecde7.clean
-- Installing: D:/packages/libsigsegv_x64-windows/share/libsigsegv/copyright
-- Performing post-build validation
warning: The folder /include is empty or not present. This indicates the library was not correctly installed.
error: Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: C:\a\1\s\ports\libsigsegv\portfile.cmake
error: building libsigsegv:x64-windows failed with: POST_BUILD_CHECKS_FAILED
@SamuelMarks SamuelMarks mentioned this pull request Dec 10, 2023
Closed
@MonicaLiu0311
Copy link
Contributor

Is there any new progress?
@MonicaLiu0311
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.
@SamuelMarks
Copy link
Contributor Author

SamuelMarks commented Jan 26, 2024 •
edited
Loading

@MonicaLiu0311 Reopen pushing some stuff up now

EDIT - Pushed up
@MonicaLiu0311 MonicaLiu0311 reopened this Jan 26, 2024
@MonicaLiu0311
Copy link
Contributor

/azp run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@MonicaLiu0311
Copy link
Contributor

Please get failure logs here.

handler.c
stackvma.c
leave.c
dispatcher.c
version.c
D:\b\libsigsegv\src\bsigsegv-2-fd354ecde7.clean\src\handler-win32.c(217): error C2039: 'Esp': is not a member of '_CONTEXT'
C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\um\winnt.h(4206): note: see declaration of '_CONTEXT'
D:\b\libsigsegv\src\bsigsegv-2-fd354ecde7.clean\src\handler-win32.c(219): error C2039: 'Eip': is not a member of '_CONTEXT'
C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\um\winnt.h(4206): note: see declaration of '_CONTEXT'
make[2]: Leaving directory '/d/b/libsigsegv/x64-windows-dbg/src'
make[1]: Leaving directory '/d/b/libsigsegv/x64-windows-dbg
@MonicaLiu0311
Copy link
Contributor

Ping @SamuelMarks
@MonicaLiu0311
Copy link
Contributor

Is there any new progress?
@SamuelMarks
Copy link
Contributor Author

@MonicaLiu0311 Why don't I just push it up without Windows support and add a new PR for Windows support (when I—or someone else—gets the time).
@SamuelMarks SamuelMarks marked this pull request as ready for review May 20, 2024 17:52
MonicaLiu0311
MonicaLiu0311 reviewed May 21, 2024
View reviewed changes
ports/libsigsegv/vcpkg.json
"version": "2.14.0",
"description": "GNU libsigsegv is a library for handling page faults in user mode.",
"homepage": "https://www.gnu.org/software/libsigsegv/",
"supports": "!uwp & !windows"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, "supports" needs to be consistent with the platform supported by the upstream. If the upstream supports the windows platform but you are currently unable to solve the problems with the windows build, please add the failed triplets to ci.baseline.txt.
@MonicaLiu0311
Copy link
Contributor

After installation, it is found that you have provided neither .pc files nor config*.cmake files. Please provide at least one usage.
MonicaLiu0311
MonicaLiu0311 reviewed May 21, 2024
View reviewed changes
ports/libsigsegv/portfile.cmake
Comment on lines +21 to +32
# --host=x86_64-w64-mingw32 --prefix=/usr/local/msvc64
# CC="$HOME/msvc/compile cl -nologo"
# CFLAGS="-MD"
# CXX="$HOME/msvc/compile cl -nologo"
# CXXFLAGS="-MD"
# CPPFLAGS="-D_WIN32_WINNT=$win32_target -I/usr/local/msvc64/include"
# LDFLAGS="-L/usr/local/msvc64/lib"
# LD="link"
# NM="dumpbin -symbols"
# STRIP=":"
# AR="$HOME/msvc/ar-lib lib"
# RANLIB=":"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments necessary?
@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft May 21, 2024 02:36
@MonicaLiu0311
Copy link
Contributor

Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review".
@MonicaLiu0311
Copy link
Contributor

Ping @SamuelMarks
@MonicaLiu0311
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
2 participants
@SamuelMarks @MonicaLiu0311