Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] SFCGAL #35831

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[NEW] SFCGAL #35831

wants to merge 4 commits into from

Conversation

lbartoletti
Copy link

SFCGAL is a C++ wrapper library around CGAL with the aim of supporting ISO
19107:2013 and OGC Simple Features Access 1.2 for 3D operations.

SFCGAL provides standard compliant geometry types and operations, that can be
accessed from its C or C++ APIs. PostGIS uses the C API, to expose some
SFCGAL's functions in spatial databases

https://gitlab.com/sfcgal/SFCGAL
https://sfcgal.org/

Nota: I am the primary maintainer of SFCGAL. I also handle its packaging on FreeBSD and MSYS2/MinGW. I commit to ensuring its maintenance and further development.

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.
SFCGAL is a C++ wrapper library around CGAL with the aim of supporting ISO
19107:2013 and OGC Simple Features Access 1.2 for 3D operations.

SFCGAL provides standard compliant geometry types and operations, that can be
accessed from its C or C++ APIs. PostGIS uses the C API, to expose some
SFCGAL's functions in spatial databases

https://gitlab.com/sfcgal/SFCGAL
https://sfcgal.org/
@FrankXie05 FrankXie05 self-assigned this Dec 22, 2023
@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 22, 2023
@FrankXie05
Copy link
Contributor

Error form CI on x86-windows :

D:\installed\x86-windows\include\CGAL/Intersections_3/internal/Bbox_3_Segment_3_do_intersect.h(142): error C2666: 'boost::operators_impl::less_than_comparable2<T,U,boost::operators_impl::equality_comparable2<T,U,B>>::operator >=': overloaded functions have similar conversions
        with
        [
            T=CGAL::Quotient<CGAL::Gmpzf>,
            U=CGAL::Gmpzf,
            B=boost::operators_impl::ordered_field_operators2<CGAL::Quotient<CGAL::Gmpzf>,int,boost::operators_impl::ordered_field_operators2<CGAL::Quotient<CGAL::Gmpzf>,double,boost::operators_impl::operators_detail::empty_base<CGAL::Quotient<CGAL::Gmpzf>>>>
        ]

install-x86-windows-dbg-out.log

@lbartoletti
Copy link
Author

@lbartoletti please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Oslandia"

@lbartoletti
Copy link
Author

Error form CI on x86-windows :

D:\installed\x86-windows\include\CGAL/Intersections_3/internal/Bbox_3_Segment_3_do_intersect.h(142): error C2666: 'boost::operators_impl::less_than_comparable2<T,U,boost::operators_impl::equality_comparable2<T,U,B>>::operator >=': overloaded functions have similar conversions
        with
        [
            T=CGAL::Quotient<CGAL::Gmpzf>,
            U=CGAL::Gmpzf,
            B=boost::operators_impl::ordered_field_operators2<CGAL::Quotient<CGAL::Gmpzf>,int,boost::operators_impl::ordered_field_operators2<CGAL::Quotient<CGAL::Gmpzf>,double,boost::operators_impl::operators_detail::empty_base<CGAL::Quotient<CGAL::Gmpzf>>>>
        ]

install-x86-windows-dbg-out.log

We haven't done it yet, but we were thinking of disabling 32-bit support. Is it possible to add a condition for vcpkg to support 64-bit architectures only?

@Neumann-A
Copy link
Contributor

We haven't done it yet, but we were thinking of disabling 32-bit support. Is it possible to add a condition for vcpkg to support 64-bit architectures only?

supports: "x64 | arm64" or !(arm32 | x86)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
3 participants